prober: added ip address to metric label#1502
Open
fluzzykitten wants to merge 2 commits into
Open
Conversation
683d407 to
d4d982d
Compare
Signed-off-by: John Bochert <JohnRBochert@gmail.com>
d4d982d to
10515ea
Compare
Signed-off-by: fluzzykitten <culturedyogurt@gmail.com>
Contributor
Author
|
Hi @brian-brazil @SuperQ , are you guys the codeowners/maintainers for the blackbox exporter? This PR adds the resolved IP address as an additional label on probe metrics, which can be very helpful for debugging when DNS resolution varies or when monitoring anycast/CDN endpoints. Would it be possible to get a review when you have a moment? Happy to make any adjustments needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Which issue(s) does the PR fix:
Adds IP address as label in returned metrics. Having the hash as a metric is lovely and all, but often you need the actual IP, which is now included as a label on metrics returned from probes.
Does this PR introduce a user-facing change?
Previously, metrics had the hash:
Now it also includes the actual IP:
Checklist
release-notessection of PR Desc.