Merged
Conversation
At the moment, nowhere using this function is giving it a string - Creates a lot of bug
- Slim refactoring of the Model class - Actually make gaml file path correction/verification used - Was stored in a private variable, but never used when getting json infos - Clean-up, log and document each parts
- Was trash, fully rework to be :
1. Readable code
- Comments
- Logically ordered
- Semi-column
2. Understandable logs (proper sentences, set at proper level)
3. Rely on other file verification and work
4. Use the Model objects, as well as properly typing elements
5. Logs and code clean-up
- Probably not finished, but already removed a lot
- Finished to replace `console.log` by logger
- Stop stringify everything, especially if it's to parse it back right after
6. Refactoring class to avoid code smells and remove dead code
7. Kept the outside logic (requesting JSON stringified with nested catalog)
- This commit should have been splitted, but since I changed everything, this comment is the log explaining it
Revert to old method which is way more reliable (since the index is managed by the backend) using the newly added `model_index` attribute in each VU_MODEL_SETTING_JSON (generated and managed by the backend, so no possible out of bound or anything)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Description
All documented in the messages of each commit. This has been a small refactoring, so the commits aren't atomic but are all documented as much as possible.
Should revert 1c6d105 before merging.
Related Issue
#112