fix(blog,site): refine blog UTM routing and changelog layout#7797
fix(blog,site): refine blog UTM routing and changelog layout#7797mhartington merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughExternalized two blog navigation URLs to prisma.io and adjusted blog internal-link routing to strip a blog prefix before pushing routes. Updated changelog pages’ layout and spacing: removed a top margin and moved/rewrote header and container structure for the changelog index and individual release pages. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/blog/src/components/utm-persistence.tsx`:
- Around line 79-88: The code that builds nextInternalHref incorrectly strips
BLOG_PREFIX from any path starting with those characters (so "/blogroll" becomes
"/roll"); change the stripping to be segment-aware by only removing BLOG_PREFIX
when it is an exact segment or followed by a slash—update the logic around
targetUrl.pathname and nextInternalHref to use a regex like
^${BLOG_PREFIX}(?:/|$) or call the canonical strip function used in
apps/blog/src/lib/url.ts (refer to BLOG_PREFIX and the nextInternalHref
construction) so router.push receives the correct path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1d1c48d0-1b7f-4cd2-8eca-63c4894acbe8
📒 Files selected for processing (4)
apps/blog/src/app/(blog)/layout.tsxapps/blog/src/components/utm-persistence.tsxapps/site/src/app/changelog/[...slug]/page.tsxapps/site/src/app/changelog/page.tsx
Prevent the blog UTM click handler from stripping `/blog` out of unrelated paths like `/blogroll` while still routing base-path links correctly. Made-with: Cursor
Summary by CodeRabbit
Style & Layout
Navigation
Behavior