Conversation
pacheco
reviewed
Mar 18, 2026
| clap = { version = "4", features = ["derive"] } | ||
| derive-where = "1.4.0" | ||
| env_logger = "0.10.0" | ||
| hashbrown = "0.16" |
Member
Author
There was a problem hiding this comment.
Because the std::HashSet doesn't have get_or_insert_with, which allows me to only clone the key if not present. Besides, hashbrown is already an indirect dependency, used by wasmparser.
pacheco
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure a new pass for this is useful.
It removed 1325 labels from reth. Does it help with APC?