Open
Conversation
manaldush
commented
Feb 19, 2026
manaldush
commented
- pg_progress_bar should be locked with PG_QS_RCV_KEY, because it is using the same shmem as pg_query_state.
- change reqid logic, now it controls backend interruptions.
- now all inter-process communication in based on shmem queue reads/sends with appropriate timeouts.
- LWLocks used instead locks, it seems quite enough.
- Change deadlock test logic, error response are normal in such cases.
1. pg_progress_bar should be locked with PG_QS_RCV_KEY, because it is using the same shmem as pg_query_state. 2. change reqid logic, now it controls backend interruptions. 3. now all inter-process communication in based on shmem queue reads/sends with appropriate timeouts. 4. LWLocks used instead locks. 5. Change deadlock test logic, error response are normal in such cases.
Contributor
|
Commit message mentions several not interdependent changes. Commit diff shows it as well. My opinion, it should be several separate commits. They could be in one Pull Request, if they are somewhat related. But if they are completely independent, then better open pull request for each of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.