Conversation
|
Thank you for your contribution to Dash! 🎉 |
camdecoster
left a comment
camdecoster
left a comment
There was a problem hiding this comment.
I left a few comments, but this looks good.
| @@ -17,6 +17,8 @@ jobs: | |||
| # This output will be 'true' if files in the 'table_related_paths' list changed, 'false' otherwise. | |||
There was a problem hiding this comment.
| # This output will be 'true' if files in the 'table_related_paths' list changed, 'false' otherwise. |
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '24' |
There was a problem hiding this comment.
It might be good to throw this value in a variable.
| pytest --headless --nopercyfinalize --junitxml=test-reports/junit_background.xml tests/background_callback -v -s | ||
|
|
||
| - name: Cleanup background processes | ||
| if: always() |
There was a problem hiding this comment.
Does this mean it will always run? If so, could you remove this line?
There was a problem hiding this comment.
I think you could move some of the repeated steps into composite actions and then call those to DRY things up.
| ( | ||
| "auto", | ||
| False, | ||
| True, | ||
| None, | ||
| None, | ||
| ), # NOT responsive on resize: config.responsive=False |
There was a problem hiding this comment.
ruff probably did this, but it would be nice to have these on one line.
| @@ -89,6 +89,8 @@ def test_tdrp001_select_rows(test): | |||
| target.row(0).select() | |||
| target.row(1).select() | |||
|
|
|||
There was a problem hiding this comment.
If this is for Chrome to stabilize, could you add a note?
| ) | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Slow and unreliable sizing tests") |
There was a problem hiding this comment.
| @pytest.mark.skip(reason="Slow and unreliable sizing tests") | |
| @pytest.mark.skip(reason="Slow and unreliable sizing tests - dash-table deprecated") |
| ) | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Slow and unreliable sizing tests") |
There was a problem hiding this comment.
| @pytest.mark.skip(reason="Slow and unreliable sizing tests") | |
| @pytest.mark.skip(reason="Slow and unreliable sizing tests - dash-table deprecated") |
| ) | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Slow and unreliable sizing tests") |
There was a problem hiding this comment.
| @pytest.mark.skip(reason="Slow and unreliable sizing tests") | |
| @pytest.mark.skip(reason="Slow and unreliable sizing tests - dash-table deprecated") |
2 participants
Migrate the circleci testing config to github action. Config only from #3655, the browser changes will come in another PR.