fix restore diff sidebar width after resize#1026
Open
donnes wants to merge 1 commit intopingdotgg:mainfrom
Open
fix restore diff sidebar width after resize#1026donnes wants to merge 1 commit intopingdotgg:mainfrom
donnes wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6464dbc to
6afe307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
The bug was caused by the diff sidebar restoring a previously saved custom width without re-checking whether that width still fit after the app window became smaller, like after unplugging a monitor.
Once that stale width no longer fit, the diff panel could end up in a broken layout state, so clicking the diff toggle button or pressing Cmd+D appeared to stop working even though the toggle logic still ran.
The fix makes the sidebar revalidate its stored width on restore and on window resize, and if that width is no longer valid, it falls back to the default sidebar width instead of keeping the broken one.
UI Changes
Demos
Before Fix
T3Code.toggle.diff.panel.not.working.demo.mp4
After Fix
T3Code.toggle.diff.panel.working.mp4
Checklist
Note
Restore diff sidebar width on window resize using
shouldAcceptWidthvalidationSidebarRailcomponent in sidebar.tsx now re-validates and re-applies the stored sidebar width on every window resize event, not just on mount.shouldAcceptWidthpredicate receives the current and next widths plus relevant DOM refs; if it rejects the width, the sidebar resets to its CSS default and clears the stored value from localStorage.sidebarInstance?.sidechanges, andonResizeis only called when a stored width is accepted.Macroscope summarized 6afe307.