fix: fall back to PATH when codex binary missing#1025
fix: fall back to PATH when codex binary missing#1025chindris-mihai-alexandru wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
Summary
Motivation
Some installs (Homebrew/npm) surface stale or invalid binary paths. Today that hard-fails sessions even when
codexis available on PATH. This change attempts the configured path first, then falls back to PATH for missing binaries.Testing
Note
Fall back to PATH
codexbinary when configured binary path is not executableresolveCodexBinaryPathin codexAppServerManager.ts to validate the configured binary viaassertSupportedCodexCliVersionbefore use."codex", the function retries with"codex"from PATH and logs a console warning.startSessionnow delegates binary resolution to this helper instead of asserting and selecting the path inline.codexon PATH if available.Macroscope summarized 102c216.