Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

ignore context deadline exceeded error for bank2 admin check table#395

Open
sticnarf wants to merge 1 commit intopingcap:masterfrom
sticnarf:bank2-false-positive
Open

ignore context deadline exceeded error for bank2 admin check table#395
sticnarf wants to merge 1 commit intopingcap:masterfrom
sticnarf:bank2-false-positive

Conversation

@sticnarf
Copy link
Contributor

Signed-off-by: Yilin Chen sticnarf@gmail.com

What problem does this PR solve?

Closes #384 again :(

What is changed and how does it work?

I don't have a good idea about solving the problem. ADMIN CHECK TABLE has various error patterns and is hard to match as well. So, still, I add "context deadline exceeded" to the filter list.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf requested a review from cosven March 29, 2021 05:42
strings.Contains(errStr, "Information schema is changed") ||
strings.Contains(errStr, "TiKV server timeout")) {
strings.Contains(errStr, "TiKV server timeout") ||
strings.Contains(errStr, "context deadline exceeded")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also add "injected" to the whitelist for testing with failpoints.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants