This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Open
Conversation
mahjonp
reviewed
Mar 25, 2021
| maxLength = flag.Int("max-value-length", 128, "maximum value inserted into rocksdb") | ||
| replicaRead = flag.String("tidb-replica-read", "leader", "tidb_replica_read mode, support values: leader / follower / leader-and-follower, default value: leader.") | ||
| dbname = flag.String("dbname", "test", "name of database to test") | ||
| randomToggleFeature = flag.Bool("random-toggle-feature", false, "") |
Contributor
There was a problem hiding this comment.
I think it's a little vague to me since there are only two toggle features here(tidb_enable_async_commit and enable-compaction-filter). Rest LGTM
Contributor
There was a problem hiding this comment.
I mean that random-toggle-feature maybe not a good name, but I have no idea about the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggle feature async-commit and gc-in-compaction-filter during test run.
cc @hicqu