Cache current benchmark version lookups#51
Open
olearycrew wants to merge 3 commits into
Open
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
pinchbench-api | cce0303 | Jun 08 2026, 06:35 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
benchmark_versions, even though the table has only a few rows and changes weekly.Root Cause
resolveBenchmarkVersions()insrc/utils/query.tsperformedSELECT id FROM benchmark_versions WHERE current = 1 AND hidden = 0on every request without aversionorbenchmark_versionquery param./api/submissions,/api/model-submissions,/api/me/submissions,/api/users/:github_username/submissions,/api/leaderboard,/api/models,/api/stats, and/api/providers/:provider/models.Solution
version/benchmark_versionbehavior: requested versions are still validated against D1 and hidden versions still resolve to an empty filter.npm auditnow reports zero vulnerabilities.Test Coverage
src/utils/query.test.tswith a production-equivalent benchmark version fixture containing current, historical, hidden, and semver/prerelease IDs.npm ciandnpm teston pushes and pull requests.How to run:
npm ci npm test npm audit --audit-level=moderateMetrics Impact
benchmark_versionstable, this reduces rows read for that hot path from roughly 385K/day to roughly 7.2K/day per warm isolate, about a 98% reduction.Risks & Mitigations
npm ci && npm test;npm audit --audit-level=moderatereports zero vulnerabilities.