fix(cli): clarify PiecesOS install completion wording#455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS and Windows the installer only downloads the package and launches the OS installer (
open/start); the user still has to finish the GUI install. The sharedDownloadState.COMPLETEDbranch printed "✅ Installed PiecesOS successfully", which overclaims on those platforms. Only Linux (snap) actually performs an in-process install.This PR makes the completion wording match what the CLI actually knows, and lightly clarifies the failure message. No install behavior or control flow changes.
Changes
src/pieces/install_messages.py: stdlib-only, pure helper functions returning per-OS install wording (mirrorsreadiness_messages.py).src/pieces/core/install_pieces_os.py: COMPLETED/FAILED branches now call the helper withplatform.system().tests/test_install_messages.py: pins the per-OS wording contract, guards the call site against reintroducing the legacy overclaiming string, and an import smoke test.Wording
📥 Downloaded PiecesOS. Finish the installation in the window that just opened, then run \pieces open`.`✅ Installed PiecesOS. Run \pieces open` to launch it.`❌ Couldn't install PiecesOS automatically — opening the manual install page in your browser.Out of scope
Vendored SDK, MCP, doctor/support artifact, os_server/runtime, SDK #144/#145 vendoring, installer behavior/control flow,
readiness_messages.py.Test plan
python -m pytest tests/test_install_messages.py -v(13 passed)python -m pytest tests/test_readiness_messages.py -v(19 passed, no regression)PYTHONPATH=src python -c "import pieces.install_messages, pieces.core.install_pieces_os"ruff check src/pieces/install_messages.py src/pieces/core/install_pieces_os.py tests/test_install_messages.py