Skip to content

Expand test suite: Behat zip inspection, functional, and unit tests#387

Merged
luispabon merged 4 commits intomasterfrom
more-tests
Mar 11, 2026
Merged

Expand test suite: Behat zip inspection, functional, and unit tests#387
luispabon merged 4 commits intomasterfrom
more-tests

Conversation

@luispabon
Copy link
Contributor

Summary

This PR expands the test suite across Behat, functional, and unit tests, and fixes PHPStan config so old configs no longer cause errors.

Changes

Behat

  • Zip inspection: New step definitions in DefaultContext for file/content checks (contain/not-contain) and AfterScenario cleanup.
  • Template: Added container_for_mariadb_* and container_for_postgres_* wrapper divs in the generator template for validation error selectors.
  • Scenarios: generator.feature expanded from 6 to 20 scenarios, covering:
    • Zip structure and PHP version in Dockerfile
    • MariaDB/PostgreSQL validation
    • Per-service docker-compose content (including credentials)
    • Optional services absent by default
    • All services enabled at once

Functional

  • Many new test cases in tests/Functional/GeneratorTest.php.

Unit

  • New test files: PostgresTypeValidatorTest, AvailableExtensionsFactoryTest, BaseAvailableExtensionsTest, ArchiverTest, and service option tests for Base, Elasticsearch, MariaDB, MySQL, Php, and Postgres.

Other

  • PHPStan: Config updated so old config no longer throws errors.
  • Generator: Small updates in GeneratorController, config/services.yaml, and templates/generator.html.twig to support the new tests.

Stats

  • 17 files changed, ~1,018 insertions, 19 deletions
  • 4 commits

luispabon and others added 4 commits March 11, 2026 22:36
… coverage

- Add zip-inspection step definitions to DefaultContext (contain/not-contain file and content checks, AfterScenario cleanup)
- Add container_for_mariadb_* and container_for_postgres_* wrapper divs to generator template to support validation error selectors
- Expand generator.feature from 6 to 20 scenarios covering zip structure, PHP version in Dockerfile, MariaDB/PostgreSQL validation, per-service docker-compose content (including credentials), optional services absent by default, and all services enabled simultaneously

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@luispabon luispabon merged commit 71eade7 into master Mar 11, 2026
1 check passed
@luispabon luispabon deleted the more-tests branch March 11, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant