Open
Conversation
Most of this is copied/adapted from board announcements to save time but there is a lot of code duplication between signatures and avatars which i'd like to resolve at some point.
There was a problem hiding this comment.
Ugly as it is...you're already using $phpbb_container to load some services. What do you think about getting the services from the container instead of using the globals? It may still be ugly, but it's only 1 global instead of 7 ??
Member
Author
There was a problem hiding this comment.
The more deeply hidden the dependencies, the uglier it is.
|
So this has been around for over 18 months. Any plans on actually doing anything here? |
|
any news? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not standard practice but I'm going to put a couple of things in this one PR.
Closes #4 and #5