Remove unused PHP_DL_TEST_EXPORTS and PHP_ZEND_TEST_EXPORTS#13080
Closed
petk wants to merge 1 commit intophp:masterfrom
Closed
Remove unused PHP_DL_TEST_EXPORTS and PHP_ZEND_TEST_EXPORTS#13080petk wants to merge 1 commit intophp:masterfrom
petk wants to merge 1 commit intophp:masterfrom
Conversation
In current code these aren't used on Windows build. The PHP_ZEND_TEST_EXPORTS was intended to fix MSVC level 1 (severe) warnings but it's not implemented yet.
Member
Author
|
On the second reconsideration, let's leave these two in for now. Sorry for the noise. Because there are other unused similar definitions and this works half way for now. |
Member
Author
|
Reopening this via #21109 to limit possible issues with unused macros and if they will be used in the future in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current code these aren't used on Windows build. The PHP_ZEND_TEST_EXPORTS was intended to fix MSVC level 1 (severe) warnings but it's not implemented yet.