fix(security): 2 improvements across 2 files#2833
Closed
tomaioo wants to merge 2 commits intophcode-dev:mainfrom
Closed
fix(security): 2 improvements across 2 files#2833tomaioo wants to merge 2 commits intophcode-dev:mainfrom
tomaioo wants to merge 2 commits intophcode-dev:mainfrom
Conversation
- Security: DOM-based XSS via unsanitized query parameters - Security: DOM-based XSS in live preview error page translations Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: DOM-based XSS via unsanitized query parameters - Security: DOM-based XSS in live preview error page translations Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
Member
|
Looks good 👍 - can you add a quick comment like: “I license this contribution under both MIT and GPL” |
Member
|
Closing due to no repose. The src-node is not available at runtime and hence is ok to drop. The live-preview-error.html is in the deployed artifact and is affected. But we cannot simply change to text content for it to work. So we have the proper fix in #2851 Closing as this is no longer current. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:src-node/www/phoenix-splash/error.html:L11The page reads
mainHeadingandmainSpanfrom URL query parameters, decodes them, and assigns them directly toinnerHTML. An attacker can craft a URL containing HTML/JS payloads that execute in the page context.Solution
Avoid
innerHTMLfor untrusted data. UsetextContent/innerTextinstead, or sanitize with a robust HTML sanitizer (e.g., DOMPurify) if HTML rendering is required.Changes
src-node/www/phoenix-splash/error.html(modified)src/assets/phoenix-splash/live-preview-error.html(modified)