Skip to content

Closes #145 — Add PP domain example using {aNCA}#161

Draft
Gero1999 wants to merge 4 commits intomainfrom
145-add-anca-example-to-interactive-page
Draft

Closes #145 — Add PP domain example using {aNCA}#161
Gero1999 wants to merge 4 commits intomainfrom
145-add-anca-example-to-interactive-page

Conversation

@Gero1999
Copy link
Copy Markdown
Collaborator

@Gero1999 Gero1999 commented Apr 24, 2026

  • Add sdtm/pp.qmd: NCA workflow from ADNCA to CDISC PP using {aNCA}
  • Add PP entry to sdtm/index.qmd under Findings

Pull Request

Adds a Pharmacokinetic Parameters (PP) domain example under SDTM → Findings, showing how to produce a CDISC-compliant PP dataset from ADNCA data using aNCA.

The example walks through the full NCA scripting workflow:

  • Load data and define column mapping
  • Set up filters, partial intervals, parameter selections, units, and flag rules
  • Create and configure a PKNCA data object
  • Run NCA calculations
  • Export CDISC datasets (PP, ADPP, ADNCA)
  • It also briefly mentions the two alternative workflows (YAML-driven script generation and Shiny app export).

Known limitations / points for review

  • The current CRAN version of the App does not have these features available. In any case, during the intro/installation this is specified for the readers so they can get the GitHub-dev version for now.

  • All code chunks use eval=FALSE — {aNCA} is not a dependency of this repo, so nothing executes during the Quarto build. This means no rendered output tables appear on the page (unlike DM/AE/VS which use print_df() to show live data). If we want rendered output, aNCA would need to be added to DESCRIPTION Imports.

  • No companion .R file — The other SDTM examples have a .R script alongside the .qmd (generated via knitr::purl()). Since all chunks are eval=FALSE, purl would produce a file with only comments. I can add one manually if preferred.

  • Spellcheck may flag new words — Terms like PKNCA, PKNCAdata, PPTESTCD, PPSTRESU, etc. may need to be added to inst/WORDLIST.

  • Style check — The styler CI job may flag formatting in the R code blocks. Since the chunks don't execute, styler may not pick them up, but worth verifying.


  • Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Landing Pages: If new packages were added or removed, update the package tables in the main landing page and the relevant section landing page(s) (sdtm/index.qmd, adam/index.qmd, tlg/index.qmd).
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.

By default, a temporary website with the content of the PR is created. To avoid this add [skip website] to the title of the PR.

- Add sdtm/pp.qmd: NCA workflow from ADNCA to CDISC PP using {aNCA}
- Add PP entry to sdtm/index.qmd under Findings
@Gero1999 Gero1999 linked an issue Apr 24, 2026 that may be closed by this pull request
@Gero1999 Gero1999 changed the title feat: add PP domain example using aNCA (#145) Closes #145 - aNCA: add PP domain example Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

@Gero1999 Gero1999 changed the title Closes #145 - aNCA: add PP domain example Closes #145 — Add PP domain example using {aNCA} Apr 24, 2026
@bms63
Copy link
Copy Markdown
Collaborator

bms63 commented Apr 24, 2026

@bundfussr I gave you admin access in case you need to update anything for branch-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add {aNCA} example to Interactive page

2 participants