Closes #159 preserve_pr_websites: keep files on gh-pages#160
Conversation
|
The website is available at https://pharmaverse.github.io/examples/159_preserve_pr_websites. |
There was a problem hiding this comment.
Hi @pawelru , why is the website built and deployed every day?
Should we add a comment here why it is necessary?
There was a problem hiding this comment.
good question - I don't quite remember the rationale to be honest. Happy to change and make it more rarely
There was a problem hiding this comment.
OK, I've removed the schedule event.
|
Hi @pawelru , could you have a look at this PR please? |
Gero1999
left a comment
There was a problem hiding this comment.
LGTM! I think the code changes make sense, my only concern is that I cannot think of any other way of testing that it works than merging to main and checking. Let me know otherwise @bundfussr!
The main risk I can think of is that the old/stale PR previews will now accumulate on gh-pages and never get cleaned up. We may need a separate cleanup job that removes previews for closed/merged PRs (if there are any). But this is not relevant at all, seems like an easy task to address
We have already a workflow which removes the PR previews when the PR is closed: https://github.com/pharmaverse/examples/blob/main/.github/workflows/remove_pr_website.yml |
I would merge it but I don't have the rights to merge. Could anyone else merge it? |
|
merging in |
Pull Request
Use
keep_files: trueto avoid that existing files on thegh-pagesbranch are removed when the website is build and deployed.Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!
Closes #<insert_issue_number>at the beginning of your PR title. Use the Edit button in the top-right if you need to update.DESCRIPTIONfile.DESCRIPTIONfile'sImportssection.sdtm/index.qmd,adam/index.qmd,tlg/index.qmd).By default, a temporary website with the content of the PR is created. To avoid this add
[skip website]to the title of the PR.