fix: strip quotes from type names in view dependency detection

[FFX3]

When a function returns a quoted type like SETOF public."ViewName", the extractBaseTypeName function was not stripping the double quotes. This caused the lookup in functionReferencesNewView to fail because the view lookup map stores unquoted names (e.g., public.viewname).

As a result, functions with quoted return types were not detected as having view dependencies, causing them to be created before the views they depend on, leading to "type does not exist" errors.

[greptile-apps]

Greptile Summary

This PR fixes a bug in extractBaseTypeName where double-quoted PostgreSQL identifiers (e.g. SETOF public."ViewName") were not having their quotes stripped before view-dependency lookup, causing functions that return quoted view types to be ordered before their dependent views — leading to type does not exist errors at runtime.

Key changes:

• Added strings.ReplaceAll(t, "\"", "") in extractBaseTypeName to strip SQL delimited-identifier quotes, so the unquoted name can be matched against the lowercase view lookup map built by buildSchemaNameLookup.
• Updated the function's doc comment to document the new stripping behavior.

Notes:

• The fix is minimal and correct for all realistic PostgreSQL type expressions (quoted schema, quoted type name, quoted SETOF types, quoted array types).
• No unit tests were added for the quoted-identifier path in extractBaseTypeName or functionReferencesNewView, leaving the fix without a regression guard.

Confidence Score: 4/5

• Safe to merge — the one-line fix is correct and non-breaking, but lacks regression tests for the new behavior.
• The change is minimal (a single strings.ReplaceAll call added after existing stripping steps), targets a well-understood code path, and introduces no new dependencies. The logic is correct: stripping SQL delimiter quotes before case-folded lookup is the right approach, and the existing downstream strings.ToLower in typeMatchesLookup handles the rest. Score is 4 rather than 5 only because the fix has no accompanying test coverage, leaving the quoted-identifier path un-guarded against future regressions.
• No files require special attention, but consider adding unit tests for extractBaseTypeName in diff_test.go.

Important Files Changed

Filename	Overview
internal/diff/diff.go	Adds strings.ReplaceAll to strip double quotes from SQL identifiers in extractBaseTypeName; fix is correct and low-risk but no unit tests were added for the new behavior.

Sequence Diagram

sequenceDiagram
    participant Diff as diff.go (orderDDLStatements)
    participant FRV as functionReferencesNewView
    participant EBT as extractBaseTypeName
    participant TML as typeMatchesLookup
    participant VL as newViewLookup (map)

    Diff->>FRV: fn, newViewLookup
    FRV->>EBT: fn.ReturnType (e.g. SETOF public."ViewName")
    EBT-->>EBT: strip SETOF → public."ViewName"
    EBT-->>EBT: strip [] → public."ViewName"
    EBT-->>EBT: strip quotes → public.ViewName  [NEW]
    EBT-->>FRV: "public.ViewName"
    FRV->>TML: typeName="public.ViewName", schema, newViewLookup
    TML-->>TML: ToLower → "public.viewname"
    TML->>VL: lookup["public.viewname"]
    VL-->>TML: found ✓
    TML-->>FRV: true
    FRV-->>Diff: true → function depends on view, order accordingly

Loading

_{Last reviewed commit: b1f3b10}

[tianzhou]

Thanks for the contribution. please add an unit test

[FFX3]

I'll take a look at adding the tests

[FFX3]

Thanks for the contribution. please add an unit test

Tests added

[tianzhou]

LGTM. Thanks for the contribution.