Skip to content

nice: Ref pad while sending signal, should fix #21516 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frederik-vestre-pexip wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nice: Ref pad while sending signal, should fix #21516 #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions gst/gstnicesink.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,16 @@ gst_nice_sink_on_overflow (GstNiceSink * sink,
if (stream_id == sink->stream_id && component_id == sink->component_id) {
GST_DEBUG_OBJECT (sink, "Sink overflow for stream %d, component %d", stream_id, component_id);

GstPad * sinkpad = GST_BASE_SINK_PAD (sink);
gst_object_ref(sinkpad);
#if GST_CHECK_VERSION (1,0,0)
gst_pad_push_event (GST_BASE_SINK_PAD (sink),
gst_pad_push_event (sinkpad,
gst_event_new_custom (GST_EVENT_CUSTOM_UPSTREAM, gst_structure_new_empty ("PexQosOverflow")));
#else
gst_pad_push_event (GST_BASE_SINK_PAD (sink),
gst_pad_push_event (sinkpad,
gst_event_new_custom (GST_EVENT_CUSTOM_UPSTREAM, gst_structure_new_empty ("PexQosOverflow")));
#endif
gst_object_unref(sinkpad);
}
}

Expand All @@ -219,14 +222,16 @@ gst_nice_sink_on_writable (GstNiceSink * sink,

if (stream_id == sink->stream_id && component_id == sink->component_id) {
GST_DEBUG_OBJECT (sink, "Sink underflow for stream %d, component %d", stream_id, component_id);

GstPad * sinkpad = GST_BASE_SINK_PAD (sink);
gst_object_ref(sinkpad);
#if GST_CHECK_VERSION (1,0,0)
gst_pad_push_event (GST_BASE_SINK_PAD (sink),
gst_pad_push_event (sinkpad,
gst_event_new_custom (GST_EVENT_CUSTOM_UPSTREAM, gst_structure_new_empty ("PexQosUnderflow")));
#else
gst_pad_push_event (GST_BASE_SINK_PAD (sink),
gst_pad_push_event (sinkpad,
gst_event_new_custom (GST_EVENT_CUSTOM_UPSTREAM, gst_structure_new_empty ("PexQosUnderflow")));
#endif
gst_object_unref(sinkpad);
}
}

Expand Down