rtpsession: iterate ssrcs copy when scheduling remaining nacks#56
Draft
Copilot wants to merge 1 commit into
Draft
rtpsession: iterate ssrcs copy when scheduling remaining nacks#56Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/pexip/gstreamer/sessions/b8e11543-63fb-48a2-bedc-0c310440a3a3 Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
camilo-celis
April 28, 2026 14:40
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rtp_session_on_timeout's finalg_hash_table_foreachwalks the livesess->ssrcstable while callingschedule_remaining_nacks, which drops the session lock to issue an upcall. If another thread inserts a source viaobtain_sourceduring that window, GLib's version check trips on resume:Changes
subprojects/gst-plugins-good/gst/rtpmanager/rtpsession.c— Apply the copy-then-iterate pattern already used by theupdate_sourceandgenerate_rtcpforeach sites earlier in the same function.clone_ssrcs_hashtablerefs each source, so the copy stays valid across the unlock window insideschedule_remaining_nacks. No callback or locking semantics change.Worth proposing upstream.