gpioioctl: Fix an issue that would cause the GPIO chip handles to be closed by GC.#68
Merged
maruel merged 1 commit intoperiph:mainfrom Apr 2, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
- Coverage 27.2% 27.2% -0.0%
=======================================
Files 96 96
Lines 11827 11834 +7
=======================================
Hits 3220 3220
- Misses 8472 8479 +7
Partials 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves:
periph/devices#105
Specifically, the Invalid File Descriptor error messages coming from GPIO.In() or GPIO.Out(). The issue was that when the impression driver did a big memory allocation, the GC was closing the file descriptors required for the GPIO system to work. The problem was that NewFile() DOES close file descriptors when the *os.File is garbage collected.
Minor tweak to close the unused (duplicate) chip rather than letting it leak or wait until GC'd.
This does not totally resolve devices #105. It's still not drawing.