Add maxRenderPixels for subtitle render downscaling#83
Merged
Conversation
Add AssHandlerConfig.maxRenderPixels to limit subtitle render resolution. When frame size exceeds this pixel count, rendering is proportionally downscaled and then scaled back up during display. This reduces CPU and memory usage on high-resolution devices (e.g., 4K TVs). Changes: - AssHandlerConfig: add maxRenderPixels parameter (default 0 = no limit) - AssHandler: add computeRenderSize() utility, apply to all setFrameSize calls, log downscaling when triggered from onSurfaceSizeChanged - AssSubtitleTextureView: scale glViewport coordinates from renderSize to surfaceSize - AssSubtitleCanvasView: scale drawBitmap with RectF when downscaled - AssTexOverlay: create smaller FBO, override getVertexTransformation to scale up in OverlayEffect pipeline - AssCanvasOverlay: scale canvas draw coordinates - AssPlayer.kt: expose config parameter in buildWithAssSupport() - README: document configuration and downscaling behavior Refs #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AssHandlerConfig.maxRenderPixels to limit subtitle render resolution. When frame size exceeds this pixel count, rendering is proportionally downscaled and then scaled back up during display. This reduces CPU and memory usage on high-resolution devices (e.g., 4K TVs).
Changes:
Refs #27