Skip to content

Send cancel()#1496

Merged
benalleng merged 2 commits intopayjoin:masterfrom
spacebear21:send-cancel
Apr 21, 2026
Merged

Send cancel()#1496
benalleng merged 2 commits intopayjoin:masterfrom
spacebear21:send-cancel

Conversation

@spacebear21
Copy link
Copy Markdown
Collaborator

Mirrors #1470 for the Sender side.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24730505449

Coverage increased (+0.02%) to 84.92%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 14 of 14 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13375
Covered Lines: 11358
Line Coverage: 84.92%
Coverage Strength: 400.63 hits per line

💛 - Coveralls

@spacebear21 spacebear21 requested a review from benalleng April 21, 2026 15:56
Copy link
Copy Markdown
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK e865893

Note to self that it might be nice to have a cancel() integration test with broadcasting a fallback tx

@benalleng benalleng merged commit 993f3b8 into payjoin:master Apr 21, 2026
23 checks passed
@spacebear21
Copy link
Copy Markdown
Collaborator Author

Note to self that it might be nice to have a cancel() integration test with broadcasting a fallback tx

this could be a e2e payjoin-cli test that fails the payjoin on purpose and validates that cli cancels and broadcasts the fallback, once #1164 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants