Skip to content

Implement native http.fetchOhttpKeys in dart#1495

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:dart-fetch-ohttp-keys
Apr 20, 2026
Merged

Implement native http.fetchOhttpKeys in dart#1495
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:dart-fetch-ohttp-keys

Conversation

@spacebear21
Copy link
Copy Markdown
Collaborator

Addresses #1362 for Dart

Authored by Claude Opus 4.7

Pull Request Checklist

Please confirm the following before requesting review:

@spacebear21 spacebear21 force-pushed the dart-fetch-ohttp-keys branch from edda76b to b8d6524 Compare April 20, 2026 17:15
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 20, 2026

Coverage Report for CI Build 24680141516

Coverage remained the same at 84.502%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12924
Covered Lines: 10921
Line Coverage: 84.5%
Coverage Strength: 408.5 hits per line

💛 - Coveralls

@spacebear21 spacebear21 requested review from benalleng and chavic April 20, 2026 17:40
Copy link
Copy Markdown
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TACK b8d6524

I brought it up in #1489 for the rust side but is making a sync version in these language bindings useful or practical at all?

@spacebear21 spacebear21 merged commit b39d0b4 into payjoin:master Apr 20, 2026
23 checks passed
@spacebear21
Copy link
Copy Markdown
Collaborator Author

is making a sync version in these language bindings useful or practical at all?

From my experience it seems like downstream languages have mostly needed async where we offer only sync, I don't recall seeing it the other way around. I'm open to it if there's real demand for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants