fix(test): remove payjoin-ffi from root CRATES and update ffi test script#1492
Conversation
Coverage Report for CI Build 24753654691Coverage remained the same at 84.92%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
989762f to
c88e353
Compare
|
I think that the |
…ript payjoin-ffi tests were either being skipped due to an unnecessary MSRV version check or entangling language binding tests with core rust CI. - Remove payjoin-ffi from CRATES in root contrib/test.sh and contrib/test_local.sh - Remove MSRV version check from payjoin-ffi/contrib/test.sh - Add cargo test for payjoin-ffi rust code - Loop over language bindings (dart, javascript, python) and run their contrib/test.sh
c88e353 to
da1eaca
Compare
Fixed, added execution permissions to dart script via |
spacebear21
left a comment
There was a problem hiding this comment.
ACK da1eaca
On second thought we could probably parallelize this so it can run on multiple threads instead of blocking on each language? I noticed Claude figured out how to do that on its own when i ask it to run FFI tests, would be nice to formalize that in contrib/test.sh too.
Nice catch! I’ll look into how Claude approached it and find the best way to formalize that in contrib/test.sh. Should have a PR up by end of the week |
Closes #1454
payjoin-ffi tests were either being skipped due to an unnecessary MSRV version check or entangling language binding tests with core rust CI.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.