Skip to content

fix(test): remove payjoin-ffi from root CRATES and update ffi test script#1492

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
caarloshenriq:fix/payjoin-ffi-test-infra
Apr 23, 2026
Merged

fix(test): remove payjoin-ffi from root CRATES and update ffi test script#1492
spacebear21 merged 1 commit intopayjoin:masterfrom
caarloshenriq:fix/payjoin-ffi-test-infra

Conversation

@caarloshenriq
Copy link
Copy Markdown
Contributor

Closes #1454

payjoin-ffi tests were either being skipped due to an unnecessary MSRV version check or entangling language binding tests with core rust CI.

  • Remove payjoin-ffi from CRATES in root contrib/test.sh and contrib/test_local.sh
  • Remove MSRV version check from payjoin-ffi/contrib/test.sh
  • Add cargo test for payjoin-ffi rust code
  • Loop over language bindings (dart, javascript, python) and run their contrib/test.sh
Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 20, 2026

Coverage Report for CI Build 24753654691

Coverage remained the same at 84.92%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13375
Covered Lines: 11358
Line Coverage: 84.92%
Coverage Strength: 400.67 hits per line

💛 - Coveralls

@caarloshenriq caarloshenriq force-pushed the fix/payjoin-ffi-test-infra branch from 989762f to c88e353 Compare April 20, 2026 13:22
Comment thread payjoin-ffi/contrib/test.sh Outdated
@benalleng
Copy link
Copy Markdown
Collaborator

I think that the dart/contrib/test.sh file needs to be given execution permission. I failed to run it from the terminal without a chmod +x PATH first.

…ript

payjoin-ffi tests were either being skipped due to an unnecessary MSRV
version check or entangling language binding tests with core rust CI.

- Remove payjoin-ffi from CRATES in root contrib/test.sh and
contrib/test_local.sh
- Remove MSRV version check from payjoin-ffi/contrib/test.sh
- Add cargo test for payjoin-ffi rust code
- Loop over language bindings (dart, javascript, python) and run their
contrib/test.sh
@caarloshenriq caarloshenriq force-pushed the fix/payjoin-ffi-test-infra branch from c88e353 to da1eaca Compare April 22, 2026 00:28
@caarloshenriq
Copy link
Copy Markdown
Contributor Author

I think that the dart/contrib/test.sh file needs to be given execution permission. I failed to run it from the terminal without a chmod +x PATH first.

Fixed, added execution permissions to dart script via git add --chmod=+x

Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK da1eaca

On second thought we could probably parallelize this so it can run on multiple threads instead of blocking on each language? I noticed Claude figured out how to do that on its own when i ask it to run FFI tests, would be nice to formalize that in contrib/test.sh too.

@spacebear21 spacebear21 merged commit 70d6897 into payjoin:master Apr 23, 2026
23 checks passed
@caarloshenriq
Copy link
Copy Markdown
Contributor Author

On second thought we could probably parallelize this so it can run on multiple threads instead of blocking on each language? I noticed Claude figured out how to do that on its own when i ask it to run FFI tests

Nice catch! I’ll look into how Claude approached it and find the best way to formalize that in contrib/test.sh. Should have a PR up by end of the week

@caarloshenriq caarloshenriq deleted the fix/payjoin-ffi-test-infra branch April 25, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow top level payjoin-ffi testing with ./contrib.test.sh

4 participants