Fix clippy::question_mark warnings in FFI load() impls#1491
Merged
DanGould merged 1 commit intopayjoin:masterfrom Apr 20, 2026
Merged
Fix clippy::question_mark warnings in FFI load() impls#1491DanGould merged 1 commit intopayjoin:masterfrom
DanGould merged 1 commit intopayjoin:masterfrom
Conversation
Replace match expressions that can be simplified with ? operator in the SessionPersister::load() implementations for both sender and receiver FFI persisters. Disclosure: I consulted Claude to understand the codebase structure, but the solution was authored by myself.
Collaborator
Coverage Report for CI Build 24623924836Coverage remained the same at 84.474%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
2 tasks
nothingmuch
approved these changes
Apr 19, 2026
Contributor
Author
|
Thank you so much everyone, glad to be part of this amazing team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pre-existing clippy::question_mark warnings in the FFI
SessionPersister::load() implementations for both sender and receiver.
These were causing Lint-FFI CI failures on PRs unrelated to payjoin-ffi,
including #1490.
Pull Request Checklist
Disclosure: I consulted Claude to understand the codebase structure,
but the solution was authored by myself.