Audit serialization trait implementations#1223
Merged
spacebear21 merged 2 commits intopayjoin:masterfrom Dec 31, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 20601614417Details
💛 - Coveralls |
Contributor
|
I don't know about the serde usage in the ffi stuff and how appropriate it is to remove it for those types Only commenting about the removal and feature gating in the payjoin crate: i don't think a feature flag for this is desirable because:
so with the feature disabled the crate couldn't be used to write a safe implementation so i think this dependence on serde in our public api is actually desirable and intended |
Collaborator
|
Removing the De/Serialize from payjoin-ffi seems appropriate, they don't do anything there and were probably just copied over unintentionally. Agreed about keeping serde tightly coupled with rust-payjoin for persistence. |
Remove unintended serde derives from types that shouldn't be serializable by default. Conditionally enable serialization behind feature flag to prevent accidental API exposure through serialization.
ad78270 to
a7352f8
Compare
a7352f8 to
9c33ef1
Compare
spacebear21
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR Audits serialization trait implementations across the codebase to prevent unintentional API exposure and reduce dependencies.
Closes #1147
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.