Unused dependency flaged by nix check#1222
Merged
benalleng merged 3 commits intopayjoin:masterfrom Dec 11, 2025
Merged
Conversation
drop the .udl match from the cleanSourceWith filter as Uniffi does not use .udl files anymore
enforces unused dependency detection in nix flake check
Collaborator
Pull Request Test Coverage Report for Build 20144561401Details
💛 - Coveralls |
benalleng
reviewed
Dec 11, 2025
| uniffi = { version = "0.30.0" } | ||
| url = "2.5.4" | ||
|
|
||
| [package.metadata.cargo-machete] |
Collaborator
There was a problem hiding this comment.
Could you explain why this is necessary here instead of a removal?
Contributor
Author
There was a problem hiding this comment.
Yeah, I kept getrandom because the wasm_js feature requires getrandom/js so it’s an actual dependency.
If you remove it and run cargo check you’ll see this.
Collaborator
There was a problem hiding this comment.
Perhaps this exclusion should be explained in a code comment here
spacebear21
reviewed
Dec 11, 2025
|
|
||
| [dependencies] | ||
| base64 = "0.22.1" | ||
|
|
spacebear21
approved these changes
Dec 11, 2025
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
Nice! I have some very minor comments but otherwise lgtm
Dropped unused dependency flagged by cargo machete across codebase. Kept getrandom because the wasm_js feature requires getrandom/js and marked it ignored in machete metadata
933bded to
fe4858c
Compare
benalleng
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following changes:
Note: I kept getrandom because the wasm_js feature requires getrandom/js so it’s an actual dependency.
If you remove it and run
cargo checkyou’ll see this.After adding machete check I ran
nix flake checkwhich displayed the log belowSecond time running after removing dependencies I got the error below. It did not catch this in the first check :
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.