Privacy bundle interface #27
Open
arminsabouri wants to merge 9 commits intomasterfrom
Open
Conversation
Previously, MakerStrategy and TakerStrategy accepted cospend proposals unconditionally: any invitation was accepted, any orderbook peer was proposed to, regardless of whether joining the session was actually cost-beneficial for the wallet. Now the makers and takers only make commital actions (agg proposals) if they their best unilateral action is no worse than the agg proposal in terms of subjective cost.
Unilateral actions include all possible subsets of payment obligations as individual plans.
makers and takers should behave uniformally. This will make future work on the cost function easier to reason about and implement. This distinction was initially created as part of a POC / testing scaffolding. Agenst will make co spends as long as there are orderbook utxos and PO's in the queue
stub the privacy cost to differentiate unilateral from cospend: unilateral transactions should cost more, but we have no privacy terms rn. This stubs a privacy weight for unilateral txs making cospends more preferabably when they are not under time pressure. Lastly, `ContributeOutputsToSession` was comparing single-PO contribution cost against the global best unilateral cost (which batches all POs), causing wallets to never contribute once accepted. Remove the cost gate from contribution
Bundles are collections of privacy metrics / measures that evaluate over a plan. A measure can output a value specific to its domain. The individual metrics define how to convert that into a satoshi amount wrt a privacy budget.
Just removing clutter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large refactor. The major changes here are: