feat(Message): Add ability to edit user prompt#505
feat(Message): Add ability to edit user prompt#505rebeccaalpert merged 2 commits intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-505.surge.sh A11y report: https://chatbot-pr-chatbot-505-a11y.surge.sh |
9094f1b to
2e25ca6
Compare
|
I noticed that when I actually updated a message, it seems to take precedence over the other content type options--just me? Screen.Recording.2025-04-02.at.4.50.52.PM.mov |
|
Oops actually update: actually it's just a "sticky" behavior for the radio button, not always the editable one. For ex it just remained stuck on the code default selection here - Screen.Recording.2025-04-02.at.4.54.38.PM.mov |
|
Good catch; thank you! |
beced76 to
952ca91
Compare
d743511 to
08c4576
Compare
|
Some remaining questions, but nothing to hold this back
|
Kayla will work on a design for the trigger and we'll get it in at that point.
We can definitely add this once we have a trigger. The placeholder only shows if there's no message text, which is uncommon. |
kaylachumley
left a comment
There was a problem hiding this comment.
Hey! to erins comment: I did make an issue to explore the trigger for the edit user prompt.
I noticed that when you drag the resizable text area, it drags over the vertical tabs. is it meant to do that?
Screen.Recording.2025-04-09.at.12.29.16.PM.mov
|
Yup, that's what PatternFly does @kaylachumley! |
| tableProps={ | ||
| variant === 'table' ? { 'aria-label': 'App information and user roles for user messages' } : undefined | ||
| } | ||
| isEditable={variant === 'editable' ? isEditable : false} |
There was a problem hiding this comment.
Do we want to toggle isEditable based on something inside the message when it's in the editable variant? It was a little odd to me using the example when I edited + saved and then couldn't get back to the edit interface without swapping to another variant and back.
I don't think this is a blocker since it's only example code quirks.
There was a problem hiding this comment.
The trigger is something design is still working out! We'll make it a little more straightforward once they've made decisions.
There was a problem hiding this comment.
its in my to do list! here is the issue for it patternfly/patternfly-design-kit#801
|
Just rebasing since another PR caused a merge conflict here. |
Add prop to trigger edit mode and display form when edit mode is on. Add examples/tests.
45aae2b to
8ee2acb
Compare
|
🎉 This PR is included in version 2.2.0-prerelease.46 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add prop to trigger edit mode and display form when edit mode is on. Add examples/tests.
Docs: https://chatbot-pr-chatbot-505.surge.sh/patternfly-ai/chatbot/messages#user-messages