Allow to tune down the logging on console.#481
Closed
pilhuhn wants to merge 1 commit intopatternfly:mainfrom
Closed
Allow to tune down the logging on console.#481pilhuhn wants to merge 1 commit intopatternfly:mainfrom
pilhuhn wants to merge 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-481.surge.sh A11y report: https://chatbot-pr-chatbot-481-a11y.surge.sh |
edonehoo
reviewed
Apr 8, 2025
| }; | ||
| ``` | ||
|
|
||
| Note, that there is also a key `verbose` that allows you to enable debugging output on web-browser console. By default, this is set to `false`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Note, that there is also a key `verbose` that allows you to enable debugging output on web-browser console. By default, this is set to `false`. | |
| - **Note:** To enable output debugging via the web-browser console, set the `verbose` key to `true`. By default, this is set to `false`. |
just the same suggestions I made in #492
Collaborator
Author
There was a problem hiding this comment.
Yes. 492 contains this PR. I originally thought the "more harmless" one could go in the 2.2.0 release.
Collaborator
Author
|
I am closing this because #492 includes this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PR, all analytics actions were unconditionally logged to console.
This PR introduces a
verboseinit prop, that allows to switch this off.TODO: how do we want to deal with this for the console provider, which is explicitly made to allow for logging to browser console?