Skip to content

feat(light-client-ext-helpers): tx-helper#2325

Merged
ryanleecode merged 2 commits intomainfrom
feat/lc-ext-helpers-tx-helper
Jul 12, 2024
Merged

feat(light-client-ext-helpers): tx-helper#2325
ryanleecode merged 2 commits intomainfrom
feat/lc-ext-helpers-tx-helper

Conversation

@ryanleecode
Copy link
Copy Markdown
Contributor

@ryanleecode ryanleecode commented Jul 12, 2024

Adds a tx-helper package to light client extension helpers.

This replaces the "copy and paste" tx-helper inside of wallet template. This new package uses the copy and pasted tx-helper but exposes a different public API. Namely one that does not have a dependnecy on @polkadot-api/observable-client & @polkadot-api/substrate-client but simply @polkadot-api/json-rpc-provider. In addition, it assumes you always want to sign the transaction at the latest best block.

This package makes integration for light client extensions easier since they only need to have a json rpc provider and a polkadot signer to sign a transaction.

Once this is merged, I will try using it in this PR to polkadot js extension and update the usage docs accordingly.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: b56ddd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@substrate/light-client-extension-helpers Minor
@substrate/wallet-template Patch
@substrate/smoldot-discovery Major
@substrate/extension Patch
@substrate/connect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryanleecode ryanleecode force-pushed the feat/lc-ext-helpers-tx-helper branch 2 times, most recently from 16a3b49 to 8e5365a Compare July 12, 2024 15:22
@ryanleecode ryanleecode requested a review from marshacb July 12, 2024 15:27
@ryanleecode ryanleecode marked this pull request as ready for review July 12, 2024 15:27
@ryanleecode ryanleecode force-pushed the feat/lc-ext-helpers-tx-helper branch from 8e5365a to 8bd76b3 Compare July 12, 2024 16:04
@ryanleecode ryanleecode enabled auto-merge (squash) July 12, 2024 16:29
@ryanleecode ryanleecode merged commit 13847b7 into main Jul 12, 2024
@ryanleecode ryanleecode deleted the feat/lc-ext-helpers-tx-helper branch July 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants