feat: add /aidd-pr skill, rename /aidd-requirements, add eval infrastructure

.github/workflows/ai-eval.yml

@@ -0,0 +1,52 @@
+name: AI Eval
+
+on:
+  schedule:
+    - cron: '0 8 * * *'
+  push:
+    paths:
+      - 'ai-evals/**'
+  pull_request:
+    paths:
+      - 'ai-evals/**'
+
+jobs:
+  ai-eval:
+    runs-on: ubuntu-latest
+    continue-on-error: true
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js 22
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Install Claude Code
+        run: npm install -g @anthropic-ai/claude-code
+
+      - name: Check Claude authentication
+        id: claude-auth
+        run: node scripts/check-claude-ai-eval-gate.js
+        env:
+          CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+
+      - name: Run AI prompt evaluations
+        if: steps.claude-auth.outputs.available == 'true'
+        env:
+          CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+        run: npm run test:ai-eval
+
+      - name: Upload AI eval responses
+        if: always() && steps.claude-auth.outputs.available == 'true'
+        uses: actions/upload-artifact@v4
+        with:
+          name: ai-eval-responses
+          path: ai-evals/*.responses.md
+          retention-days: 14

.github/workflows/test.yml

@@ -32,43 +32,3 @@ jobs:
 
       - name: Run tests
         run: npm test
-
-  ai-eval:
-    runs-on: ubuntu-latest
-    needs: test
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Setup Node.js 22
-        uses: actions/setup-node@v4
-        with:
-          node-version: 22
-          cache: 'npm'
-
-      - name: Install dependencies
-        run: npm install
-
-      - name: Install Claude Code
-        run: npm install -g @anthropic-ai/claude-code
-
-      - name: Check Claude authentication
-        id: claude-auth
-        run: node scripts/check-claude-ai-eval-gate.js
-        env:
-          CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
-
-      - name: Run AI prompt evaluations
-        if: steps.claude-auth.outputs.available == 'true'
-        env:
-          CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
-        run: npm run test:ai-eval
-
-      - name: Upload AI eval responses
-        if: always() && steps.claude-auth.outputs.available == 'true'
-        uses: actions/upload-artifact@v4
-        with:
-          name: ai-eval-responses
-          path: ai-evals/*.responses.md
-          retention-days: 14

AGENTS.md

@@ -58,3 +58,4 @@ import aidd-custom/AGENTS.md // settings from this import should override the ro
 ## Task Index
 
 fix bug => /aidd-fix
+review pull request => /aidd-pr

README.md

@@ -465,7 +465,7 @@ Skills are reusable agent workflows that extend AIDD with specialized capabiliti
 - **[/aidd-ecs](ai/skills/aidd-ecs/README.md)** — Enforces @adobe/data/ecs best practices. Use when working with ECS components, resources, transactions, actions, systems, or services.
 - **[/aidd-error-causes](ai/skills/aidd-error-causes/README.md)** — Structured error handling with the error-causes library. Use when throwing errors, catching errors, defining error types, or implementing error routing.
 - **[/aidd-fix](ai/skills/aidd-fix/README.md)** — Fix a bug or implement review feedback following the AIDD fix process. Use when a bug has been reported, a failing test needs investigation, or a code review has returned feedback that requires a code change.
-- **[/aidd-functional-requirements](ai/skills/aidd-functional-requirements/README.md)** — Write functional requirements for a user story. Use when drafting requirements, specifying user stories, or when the user asks for functional specs.
+- **[/aidd-requirements](ai/skills/aidd-requirements/README.md)** — Write functional requirements for a user story. Use when drafting requirements, specifying user stories, or when the user asks for functional specs.
 - **[/aidd-javascript](ai/skills/aidd-javascript/README.md)** — JavaScript and TypeScript best practices and guidance. Use when writing, reviewing, or refactoring JavaScript or TypeScript code.
 - **[/aidd-javascript-io-effects](ai/skills/aidd-javascript-io-effects/README.md)** — Isolate network I/O and side effects using the saga pattern with call and put. Use when making network requests, invoking side effects, or implementing Redux sagas.
 - **[/aidd-jwt-security](ai/skills/aidd-jwt-security/README.md)** — JWT security review patterns. Use when reviewing or implementing authentication code, token handling, or session management.

ai-evals/aidd-parallel/fixtures/add.js

@@ -0,0 +1 @@
+export const add = (a, b) => a - b;

ai-evals/aidd-parallel/fixtures/greet.js

@@ -0,0 +1 @@
+export const greet = (name) => `Hello, ${name}`;

ai-evals/aidd-parallel/prompt-generation-test.sudo

@@ -0,0 +1,21 @@
+import 'ai/skills/aidd-parallel/SKILL.md'
+
+userPrompt = """
+Run /aidd-parallel --branch feature/utils with the following two tasks:
+
+Task 1:
+  File: ai-evals/aidd-parallel/fixtures/add.js, line 1
+  "add() subtracts instead of adding — should use + not -"
+
+Task 2:
+  File: ai-evals/aidd-parallel/fixtures/greet.js, line 1
+  "greet() should include an exclamation mark at the end of the greeting"
+
+Generate delegation prompts for both tasks.
+"""
+
+- Given two tasks and a branch, should generate a separate delegation prompt for each task
+- Given a generated prompt, should start with /aidd-fix
+- Given a generated prompt, should reference the correct branch feature/utils
+- Given a generated prompt, should instruct the sub-agent to commit and push to origin/feature/utils
+- Given a generated prompt, should be wrapped in a markdown codeblock

ai-evals/aidd-pr/fixtures/add.js

@@ -0,0 +1 @@
+export const add = (a, b) => a - b;

ai-evals/aidd-pr/fixtures/greet.js

@@ -0,0 +1 @@
+export const greet = (name) => `Hello, ${name}!`;

ai-evals/aidd-pr/step-1-triage-test.sudo

@@ -0,0 +1,25 @@
+import 'ai/skills/aidd-pr/SKILL.md'
+
+userPrompt = """
+You have the following mock tools available. Use them instead of real gh or GraphQL calls:
+
+mock gh pr view => returns:
+  title: Fix utility functions
+  branch: feature/utils
+  base: main
+
+mock gh api (list review threads) => returns:
+  [
+    { id: "T_01", resolved: false, file: "ai-evals/aidd-pr/fixtures/add.js", line: 1, body: "add() subtracts instead of adding — should use + not -" },
+    { id: "T_02", resolved: false, file: "ai-evals/aidd-pr/fixtures/greet.js", line: 1, body: "greet() should include an exclamation mark at the end of the greeting" }
+  ]
+
+mock GraphQL resolveReviewThread => returns: { thread: { isResolved: true } }
+
+Run step 1 of /aidd-pr: triage the review threads.
+"""
+
+- Given the mock gh api returns two threads, should list both threads before taking any action
+- Given a thread whose concern is already fixed in the current source, should classify it as addressed
+- Given a thread whose reported issue is still present in the current source, should classify it as remaining
+- Given the addressed list is presented, should require approval before resolving

ai-evals/aidd-pr/step-2-delegation-test.sudo

@@ -0,0 +1,26 @@
+import 'ai/skills/aidd-pr/SKILL.md'
+
+userPrompt = """
+You have the following mock tools available. Use them instead of real gh or GraphQL calls:
+
+mock gh pr view => returns:
+  title: Fix utility functions
+  branch: feature/utils
+  base: main
+
+mock GraphQL resolveReviewThread => returns: { thread: { isResolved: true } }
+
+Triage is complete. The following issues remain unresolved:
+
+Issue 1 (thread ID: T_01):
+  File: ai-evals/aidd-pr/fixtures/add.js, line 1
+  "add() subtracts instead of adding — should use + not -"
+
+Generate delegation prompts for the remaining issues.
+"""
+
+- Given one remaining issue, should generate a delegation prompt for it
+- Given a delegation prompt, should start with /aidd-fix
+- Given a delegation prompt, should reference the specific file from the review comment
+- Given a delegation prompt, should instruct the agent to commit directly to the PR branch feature/utils and not create a new branch
+- Given a delegation prompt, should be wrapped in a markdown codeblock

ai/commands/aidd-parallel.md

@@ -0,0 +1,10 @@
+---
+description: Generate /aidd-fix delegation prompts for a list of tasks and optionally dispatch them to sub-agents in dependency order
+---
+# 🔀 /aidd-parallel
+
+Load and execute the skill at `ai/skills/aidd-parallel/SKILL.md`.
+
+Constraints {
+  Before beginning, read and respect the constraints in /aidd-please.
+}

ai/commands/aidd-pr.md

@@ -0,0 +1,10 @@
+---
+description: Review a PR, resolve addressed comments, and generate /aidd-fix delegation prompts for remaining issues
+---
+# 🔍 /aidd-pr
+
+Load and execute the skill at `ai/skills/aidd-pr/SKILL.md`.
+
+Constraints {
+  Before beginning, read and respect the constraints in /aidd-please.
+}

ai/commands/aidd-requirements.md

@@ -0,0 +1,10 @@
+---
+description: Write functional requirements for a user story. Use when drafting requirements, specifying user stories, or when the user asks for functional specs.
+---
+# 📋 /aidd-requirements
+
+Load and execute the skill at `ai/skills/aidd-requirements/SKILL.md`.
+
+Constraints {
+  Before beginning, read and respect the constraints in /aidd-please.
+}

ai/commands/aidd-riteway-ai.md

@@ -0,0 +1,10 @@
+---
+description: Write correct riteway ai prompt evals for multi-step tool-calling flows. Use when creating .sudo eval files or testing agent skills that use tools.
+---
+# 🧪 /aidd-riteway-ai
+
+Load and execute the skill at `ai/skills/aidd-riteway-ai/SKILL.md`.
+
+Constraints {
+  Before beginning, read and respect the constraints in /aidd-please.
+}

ai/commands/index.md

@@ -16,6 +16,30 @@ Rank files by hotspot score to identify prime candidates for refactoring before
 
 *No description available*
 
+### 🔀 /aidd-parallel
+
+**File:** `aidd-parallel.md`
+
+Generate /aidd-fix delegation prompts for a list of tasks and optionally dispatch them to sub-agents in dependency order
+
+### 🔍 /aidd-pr
+
+**File:** `aidd-pr.md`
+
+Review a PR, resolve addressed comments, and generate /aidd-fix delegation prompts for remaining issues
+
+### 📋 /aidd-requirements
+
+**File:** `aidd-requirements.md`
+
+Write functional requirements for a user story. Use when drafting requirements, specifying user stories, or when the user asks for functional specs.
+
+### 🧪 /aidd-riteway-ai
+
+**File:** `aidd-riteway-ai.md`
+
+Write correct riteway ai prompt evals for multi-step tool-calling flows. Use when creating .sudo eval files or testing agent skills that use tools.
+
 ### Commit
 
 **File:** `commit.md`

ai/skills/aidd-parallel/README.md

@@ -0,0 +1,64 @@
+# aidd-parallel — Parallel Sub-Agent Delegation
+
+`/aidd-parallel` generates focused `/aidd-fix` delegation prompts for a list
+of tasks and can dispatch them to sub-agents in dependency order.
+
+## Usage
+
+```
+/aidd-parallel [--branch <branch>] <tasks>   — generate one /aidd-fix delegation prompt per task
+/aidd-parallel delegate                       — build file list + dep graph, sequence, and dispatch
+```
+
+## Why parallel delegation matters
+
+When a PR review or task breakdown produces multiple independent issues, fixing
+them sequentially in a single agent thread wastes time and dilutes attention.
+`/aidd-parallel` extracts the delegation pattern into a reusable skill so any
+workflow — PR review, task execution, epic delivery — can fan work out to
+focused sub-agents without reimplementing prompt generation logic.
+
+## How it works
+
+### Step 1 — Resolve the branch
+
+If `--branch <branch>` is supplied, use that branch. If omitted, the current
+branch is detected automatically via `git rev-parse --abbrev-ref HEAD`.
+
+### Step 2 — Generate delegation prompts
+
+For each task, one `/aidd-fix` delegation prompt is produced. Every prompt:
+
+- Starts with `/aidd-fix`
+- Contains only the context needed for that single task
+- Instructs the sub-agent to work directly on the target branch and commit and
+  push to `origin/<branch>` — never to `main`, never to a new branch
+- Is wrapped in a fenced markdown codeblock; any nested codeblocks are indented
+  one level to prevent them from breaking the outer fence
+
+### Step 3 (delegate only) — Build the dependency graph
+
+`/aidd-parallel delegate` first builds a list of files each task will change,
+then produces a Mermaid change dependency graph. The graph is used for
+sequencing only — it is not saved or committed.
+
+### Step 4 (delegate only) — Dispatch in dependency order
+
+Prompts are dispatched to sub-agent workers in the order determined by the
+dependency graph: tasks with no dependencies first, dependents after their
+prerequisites are complete.
+
+Post-dispatch callbacks (e.g. resolving PR conversation threads) are the
+caller's responsibility.
+
+## When to use `/aidd-parallel`
+
+- A PR review has multiple independent issues that should be fixed in parallel
+- A task epic has been broken into independent sub-tasks suitable for parallel execution
+- Any workflow that needs to fan work out to multiple `/aidd-fix` sub-agents
+
+## Constraints
+
+- Each prompt must be wrapped in a markdown codeblock
+- Nested codeblocks inside a prompt must be indented to prevent breaking the outer fence
+- Sub-agents are always directed to the supplied branch — never to `main` or a new branch

ai/skills/aidd-parallel/SKILL.md

@@ -0,0 +1,60 @@
+---
+name: aidd-parallel
+description: >
+  Generate /aidd-fix delegation prompts for a list of tasks and optionally dispatch
+  them to sub-agents in dependency order.
+  Use when fanning work out to parallel sub-agents, generating fix delegation prompts
+  for multiple tasks, or coordinating multi-task execution across a shared branch.
+compatibility: Requires git available in the project.
+---
+
+# 🔀 aidd-parallel
+
+Act as a top-tier software engineering lead to generate focused `/aidd-fix`
+delegation prompts and coordinate parallel sub-agent execution.
+
+Competencies {
+  parallel task decomposition
+  dependency graph analysis
+  sub-agent delegation via /aidd-fix
+  branch-targeted prompt generation
+}
+
+Constraints {
+  Put each delegation prompt in a markdown codeblock, indenting any nested codeblocks to prevent breaking the outer block
+  Instruct each sub-agent to work directly on the supplied branch and commit and push to origin on that branch (not to main, not to their own branch)
+  If --branch is omitted, use the current branch (git rev-parse --abbrev-ref HEAD)
+}
+
+## Command: /aidd-parallel [--branch <branch>] <tasks>
+
+generateDelegationPrompts(tasks, branch) => prompts {
+  1. Resolve the branch: if --branch is supplied use it; otherwise run `git rev-parse --abbrev-ref HEAD`
+  2. For each task, generate a focused `/aidd-fix` delegation prompt:
+     - Start the prompt with `/aidd-fix`
+     - Include only the context needed to address that single task
+     - Instruct the sub-agent to work directly on `<branch>`, commit, and push to `origin/<branch>`
+     - Do NOT instruct the sub-agent to create a new branch
+  3. Wrap each prompt in a fenced markdown codeblock; indent any nested codeblocks by one level to prevent them from breaking the outer fence
+  4. Output one codeblock per task
+}
+
+## Command: /aidd-parallel delegate
+
+delegate(tasks, branch) {
+  1. Call generateDelegationPrompts to produce one prompt per task
+  2. Build a list of files that each task will need to change
+  3. Build a Mermaid change dependency graph from the file list
+     - Nodes are files; edges represent "must be complete before" relationships
+     - This graph is for sequencing reference only — do not save or commit it
+  4. Use the dependency graph to determine dispatch order:
+     - Tasks with no dependencies first
+     - Dependent tasks after their prerequisites are complete
+  5. Spawn one sub-agent worker per prompt in dependency order
+  6. Post-dispatch callbacks (e.g. resolving PR threads) are the caller's responsibility
+}
+
+Commands {
+  /aidd-parallel [--branch <branch>] <tasks> - generate one /aidd-fix delegation prompt per task
+  /aidd-parallel delegate [--branch <branch>] <tasks> - build file list + mermaid dep graph, sequence, and dispatch to sub-agents
+}