You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small pull requests which makes minor performance improvements to the libraries
Eliminates an additional tick by checking the length before hand and if it needs to be started (fyi each unnecessary tick hurts a kitten 🐱 )
Use filter instead of splice
Removing the use of splice and for loop in destroy method with filter since it's more efficient and IMO more clearer though.
Additional discussions:
Replacing the for loop in tick function too
I did not make a PR with that, since that's a big function and there's only one scenario (when animation ends) we need to make any mutations to the array, so doing a filter will make the code clunky, but this is something I would like to discuss further.
@pakastin Yup custom for loop filter would be faster, and we can do a remove function, which can be used at both places but the problem with that is, more code, while filter is simple and fast enough for our usage, there's a considerable difference between splice and the filter method, custom for loop filter overkill maybe, as it's going to be used at only one place. Check out the jsPerf benchmarks I linked to 😄
@pakastin Yup custom for loop filter would be faster, and we can do a remove function, which can be used at both places but the problem with that is, more code, while filter is simple and fast enough for our usage, there's a considerable difference between splice and the filter method, custom for loop filter overkill maybe, as it's going to be used at only one place. Check out the jsPerf benchmarks I linked to 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small pull requests which makes minor performance improvements to the libraries
filterinstead of spliceRemoving the use of splice and for loop in
destroymethod with filter since it's more efficient and IMO more clearer though.Additional discussions:
I did not make a PR with that, since that's a big function and there's only one scenario (when animation ends) we need to make any mutations to the array, so doing a filter will make the code clunky, but this is something I would like to discuss further.
have a nice day. thanks for this library