Skip to content

feat: make fsync configurable via fraction config#417

Open
dmedovich wants to merge 1 commit into
ozontech:mainfrom
dmedovich:199-configurable-fsync-per-fraction
Open

feat: make fsync configurable via fraction config#417
dmedovich wants to merge 1 commit into
ozontech:mainfrom
dmedovich:199-configurable-fsync-per-fraction

Conversation

@dmedovich
Copy link
Copy Markdown

@dmedovich dmedovich commented May 4, 2026

Fixes #199

Added SkipFsync bool to frac.Config and common.SealParams.
So fsync can be disabled at the fraction level, not just globally via resources.skip_fsync.
Useful in unit tests — setting frac.Config{SkipFsync: true} cuts test time roughly in half when running hundreds of tests. Global resources.skip_fsync still works and now propagates into fraction config automatically on startup.


  • I have read and followed all requirements in CONTRIBUTING.md
  • I used LLM/AI assistance to make this pull request

Model: -
Prompt: -

@cheb0 cheb0 self-requested a review May 15, 2026 12:57
Copy link
Copy Markdown
Collaborator

@cheb0 cheb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me. let's enable skip fsync feature in fraction_test.go

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (b4b9f19) to head (6d9505f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
frac/active_sealing_source.go 42.85% 2 Missing and 2 partials ⚠️
cmd/seq-db/seq-db.go 0.00% 2 Missing ⚠️
frac/active.go 71.42% 2 Missing ⚠️
frac/sealed/sealing/sealer.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   71.46%   71.46%   -0.01%     
==========================================
  Files         219      219              
  Lines       16448    16455       +7     
==========================================
+ Hits        11755    11759       +4     
- Misses       3820     3824       +4     
+ Partials      873      872       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make calling fsync configurable via fraction config

3 participants