feat: implement LID block size config#405
Open
cheb0 wants to merge 4 commits into
Open
Conversation
Contributor
|
❌ PR Title Validation Failed |
cheb0
force-pushed
the
330-lid-block-size-config
branch
from
d8f7ee7 to
7e69736
Compare
Contributor
|
❌ PR Title Validation Failed |
cheb0
force-pushed
the
330-lid-block-size-config
branch
from
7e69736 to
f781743
Compare
Contributor
|
❌ PR Title Validation Failed |
cheb0
changed the title
eguguchkin
requested review from
dkharms,
eguguchkin and
moflotas
and removed request for
moflotas
# Conflicts: # frac/sealed/sealing/index.go
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 70.65% 70.58% -0.07%
==========================================
Files 219 219
Lines 16967 16985 +18
==========================================
+ Hits 11988 11989 +1
- Misses 4084 4096 +12
- Partials 895 900 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkharms
reviewed
May 12, 2026
| SealedZstdCompressionLevel int `config:"sealed_zstd_compression_level" default:"3"` | ||
| DocBlockZstdCompressionLevel int `config:"doc_block_zstd_compression_level" default:"3"` | ||
| // LIDBlockSize sets max lids (postings) saved per LIDs block. | ||
| LIDBlockSize Bytes `config:"lid_block_size" default:"64KiB"` |
Member
There was a problem hiding this comment.
I suggest to get rid of this nonsense with Bytes because we do not build blocks by examining size of block but just by examining count of LIDs inside a block:
for _, lid := range lidsbuf {
// Flush if there is more LIDs than specified threshold.
if len(a.currentBlock.payload.LIDs) == a.blockCapacity {
if err := a.onBlock(a.finalizeBlock()); err != nil {
return err
}
a.currentBlock.payload.LIDs = a.currentBlock.payload.LIDs[:0]
...
}
...
}Migration is gonna be painless since this is how we store this information in .info file:
seq-db ⟩ cat /tmp/tmp.mCJYmApMn2/seq-db-01KREF7BBEPZ0KB0HZZ1CCKP33.info
SEQM{..., "const_lid_block_cap":65536, ...}
What do you think? This is bugging me for a very long time, honestly.
dkharms
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow to configure LID block size.
Fixes #330