Skip to content

Expose more optional parameters for setting web session #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Favo02 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

Expose more optional parameters for setting web session #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sihl/src/web_session.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ let get_all
let set
?(cookie_key = "_session")
?(secret = Core_configuration.read_secret ())
?(expires = `Session)
?(scope = Uri.of_string "/")
?(same_site = `Lax)
?(secure = false)
?(http_only = false)
session
resp
=
Expand All @@ -71,7 +76,11 @@ let set
let cookie_value = Session.to_json session in
let cookie = cookie_key, cookie_value in
Opium.Response.add_cookie_or_replace
~scope:(Uri.of_string "/")
~expires:expires
~scope:scope
~same_site:same_site
~secure:secure
~http_only:http_only
~sign_with:signed_with
cookie
resp
Expand Down