Conversation
Contributor
Author
|
Looks like we're hitting this issue rustls/rustls-platform-verifier#214, which was fixed in |
inickles
force-pushed
the
inickles/rustls
branch
2 times, most recently
from
8c1c950 to
4edb9f4
Compare
ahl
reviewed
Apr 27, 2026
| oauth2 = { workspace = true } | ||
| oauth2-reqwest = { workspace = true } | ||
| open = { workspace = true } | ||
| oxide = { workspace = true, features = ["clap", "extras"] } |
Collaborator
There was a problem hiding this comment.
did you want to use this feature you added to the sdk?
Collaborator
There was a problem hiding this comment.
nevermind: you explicitly don't want to use this.
Contributor
Author
There was a problem hiding this comment.
I wanted to expose it to users in case they wanted/needed to preserve the original behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unsets the
native-tls-vendoredfeature forreqwestby default for both the SDK and CLI, causing them to use the default TLS providerrustls, but makes an optional features for both packages to reenable for users who still want to usenative-tls-vendored.This feature flag to
reqwestwas initially added in #526. Those functionsdanger_accept_invalid_hostnamesanddanger_accept_invalid_certsseem to no longer need thenative-tls-vendoredfeature (https://docs.rs/reqwest/0.13.2/reqwest/struct.ClientBuilder.html#method.danger_accept_invalid_hostnames), though they are now deprecated, but the same can be said for the new functions that replace them.I've added a commit to move off the deprecated functions.