Restore the ability to use Clippy and fix +-50 lints#251
Open
daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
Open
Restore the ability to use Clippy and fix +-50 lints#251daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
Conversation
Author
|
Filed an issue in Clippy reporting the broken lint: rust-lang/rust-clippy#16897 |
citrus-it
reviewed
Apr 23, 2026
Comment on lines
6
to
8
| # | ||
| # Report a specific error in the case that the toolchain is too old for | ||
| # let-else: |
Contributor
There was a problem hiding this comment.
Suggest this comment is removed, or updated to explain what it is in 1.70.0 that we depend on.
Author
There was a problem hiding this comment.
Good call out. I want to bump the MSRV in a subsequent PR, which'll allow us to use edition 2024 and get some nice additional Clippy-driven syntax cleanups.
| || relpath.starts_with("kernel") | ||
| || relpath == PathBuf::from("usr") | ||
| || relpath == PathBuf::from("usr/share") | ||
| || *relpath == *"usr" |
Contributor
There was a problem hiding this comment.
How about the more natural
relpath == Path::new("usr")
instead of the double deref?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed clippy was spewing lints but unable to fix them. For some reason the
cmp_ownedlint results in non-compileable code. After manually fixing those four locations and integrating @jclulow's suggestions from now-cancelled #249 this PR results.