Makefile produces release-mode helios-build#250
Open
daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
Open
Makefile produces release-mode helios-build#250daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
daniel-levin wants to merge 1 commit intooxidecomputer:masterfrom
Conversation
Contributor
|
I bet more people than I have aliases and such like that rely on the path, but that is no reason to not go ahead. @jclulow will definitely know more about whether there's a particular reason this is currently using debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the risk of disrespectfully ripping up and then throwing away Chesterton's fence, I would like to suggest that make produces a release build of
helios-build. I did a brief sanity check and it looks like nothing else on GitHub has a dependency on the path withdebug.Open question: is there any non-obvious dependency we have on the debug build? Debug symbols or specific panic behavior or something?