Fix/textarea confirm and tui polish#9
Fix/textarea confirm and tui polish#9superbusinesstools wants to merge 3 commits intooxgeneral:mainfrom
Conversation
Pressing Enter inside wizard textareas (goal/task/agent descriptions) adds a newline — there was no Linux-friendly way to confirm. Ctrl+Enter is indistinguishable from Enter in most Linux terminals, so the only confirm path was unusable. Ctrl+S now confirms any textarea step in FormWizard. It is surfaced in the bottom CommandBar, which switches to step-specific hints while a wizard is open (bold amber Ctrl+S for textareas, step-appropriate hints for text/select/multiselect). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two small UX fixes: * Empty single-line inputs rendered the cursor after the placeholder, making it look like the cursor was floating mid-line. Render cursor before placeholder so it sits at column 0, matching user expectation. * Reopening the edit-agent wizard immediately after saving showed the pre-save values because refreshAll() is async. Merge the returned agent into liveAgents synchronously in the save callback, and add liveAgents to launchEditAgentWizard's dependency array so the wizard uses the latest snapshot. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Convenience scripts for testing a local build against the globally-installed orch binary. dev-link.sh builds and npm-links the fork; dev-unlink.sh restores the global install. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
🎉 Thanks for your first PR to ORCH! We're excited to review your contribution.
Our CI will run automatically:
- ✅ TypeScript strict mode check (
tsc --noEmit) - ✅ Full test suite (1493+ tests via Vitest)
- ✅ ESM build verification
A maintainer will review your changes shortly. In the meantime, check the Contributing Guide to make sure everything is in order.
⭐ If you enjoy working with ORCH, a star on the repo goes a long way!
|
Thanks for this — the Ctrl+Enter → Ctrl+S swap and cursor-at-col-0 are exactly the kind of Linux polish the TUI needed. Clean commits, good tests 🙌 One blocker + a small ask before merge: 🔴 Blocker —
|
|
One more follow-up after a deeper pass — a subtle render issue worth catching before merge:
|
Summary
Fixes a few TUI paper-cuts around the goal/task/agent wizards, found while using the editor on Linux.
Ctrl+S save descriptionfor textareas so users can see the binding without hunting.refreshAll()is async. The returned agent is now merged intoliveAgentssynchronously in the save callback.scripts/dev-link.sh/scripts/dev-unlink.shto build and link the fork against the globally-installedorchbinary for local testing.Test plan
npx vitest run test/unit/tui/form-wizard.test.tsx— 52/52 pass (2 new tests added for Ctrl+S)npm run build— green