Stream large database exports#224
Open
sureshchouksey8 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #59
Summary
Fixes #59 with a shared streaming export path for the SQL dump, CSV, and JSON export endpoints so large tables are exported in bounded pages instead of being materialized into one in-memory payload.
What changed
/export/dumpto stream schema and INSERT statements progressively./export/csv/:tableNameand/export/json/:tableNameto stream rows progressively instead of loading the whole table before creating the response.rowidfor tables without a primary key.Why this should help large databases
The previous implementation loaded all exported rows into memory before sending a response. This branch sends a
ReadableStreamresponse and reads rows in bounded pages, which keeps memory bounded and starts returning bytes immediately for large exports.Verification
npx -y pnpm@9.15.4 install --frozen-lockfile --ignore-scriptsnpx -y pnpm@9.15.4 exec vitest --run src/export✅ 5 files / 34 testsgit diff --check✅I also ran
npx -y pnpm@9.15.4 exec tsc --noEmit --pretty false; it still reports existing unrelated project type errors in CDC/cache/DO/operation tests, with no errors from the export files changed here.