Conversation
7585ed7 to
c8f3f22
Compare
c8f3f22 to
e1977ce
Compare
e1977ce to
8b8c50d
Compare
8b8c50d to
0692c15
Compare
0692c15 to
9f27484
Compare
9f27484 to
b2816e5
Compare
b2816e5 to
e51e325
Compare
📝 WalkthroughWalkthroughThis pull request adds changelog documentation for release v26.2.4 across five Ory projects (Keto, Kratos, Oathkeeper, OAuth2, and Polis), documenting a Helm chart repository URL migration from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/self-hosted/oel/kratos/changelog/v26.2.4.md`:
- Around line 18-19: Change the phrase "from a time where these UUIDs were
dynamic" to "from a time when these UUIDs were dynamic" in the changelog
sentence that mentions the `identity_credential_types` table and non-standard
UUIDs so the grammar reads correctly.
- Around line 28-30: The three example endpoints show inconsistent query
parameter casing: update the second endpoint `GET
/admin/sessions/{id}?expand=Identity` to use the same lowercase parameter as the
others (`expand=identity`) so all examples (`GET
/admin/sessions?expand=identity`, `GET /admin/sessions/{id}?expand=identity`,
`GET /admin/identities/{id}/sessions`) are consistent and copy/paste-safe.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 77cc614c-79b5-4811-a68b-56b6d30e44d3
📒 Files selected for processing (5)
docs/self-hosted/oel/keto/changelog/v26.2.4.mddocs/self-hosted/oel/kratos/changelog/v26.2.4.mddocs/self-hosted/oel/oathkeeper/changelog/v26.2.4.mddocs/self-hosted/oel/oauth2/changelog/v26.2.4.mddocs/self-hosted/oel/polis/changelog/v26.2.4.md
| This also works for self-hosted installations that have non-standard UUIDs in the `identity_credential_types` table, from a time | ||
| where these UUIDs were dynamic (they now are constants). |
There was a problem hiding this comment.
Grammar tweak: use “when” instead of “where”.
“from a time where these UUIDs were dynamic” reads awkwardly in docs; “when” is the correct form.
Suggested patch
-This also works for self-hosted installations that have non-standard UUIDs in the `identity_credential_types` table, from a time
-where these UUIDs were dynamic (they now are constants).
+This also works for self-hosted installations that have non-standard UUIDs in the `identity_credential_types` table, from a time
+when these UUIDs were dynamic (they now are constants).🧰 Tools
🪛 LanguageTool
[grammar] ~18-~18: Ensure spelling is correct
Context: ...ity_credential_types` table, from a time where these UUIDs were dynamic (they now are ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/self-hosted/oel/kratos/changelog/v26.2.4.md` around lines 18 - 19,
Change the phrase "from a time where these UUIDs were dynamic" to "from a time
when these UUIDs were dynamic" in the changelog sentence that mentions the
`identity_credential_types` table and non-standard UUIDs so the grammar reads
correctly.
| - `GET /admin/sessions?expand=identity` | ||
| - `GET /admin/sessions/{id}?expand=Identity` | ||
| - `GET /admin/identities/{id}/sessions` |
There was a problem hiding this comment.
Fix query parameter casing for consistency (expand=Identity vs expand=identity).
Line 29 uses expand=Identity while Line 28 uses expand=identity; this likely confuses copy/paste usage and should be standardized.
Suggested patch
-- `GET /admin/sessions/{id}?expand=Identity`
+- `GET /admin/sessions/{id}?expand=identity`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/self-hosted/oel/kratos/changelog/v26.2.4.md` around lines 28 - 30, The
three example endpoints show inconsistent query parameter casing: update the
second endpoint `GET /admin/sessions/{id}?expand=Identity` to use the same
lowercase parameter as the others (`expand=identity`) so all examples (`GET
/admin/sessions?expand=identity`, `GET /admin/sessions/{id}?expand=identity`,
`GET /admin/identities/{id}/sessions`) are consistent and copy/paste-safe.
e51e325 to
8daf6aa
Compare
Update OEL changelog
Summary by CodeRabbit
New Features
oauth2.preserve_ext_claimsconfiguration option for custom claims handlingBug Fixes
Performance
Chores
k8s.ory.shtok8s.ory.com