Conversation
opficdev
commented
Mar 5, 2026
opficdev
commented
- closed iOS 18이하에서 Menu의 체크마크 색을 파란색으로 수정한다 #188
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 앱 내 메뉴 컴포넌트의 일관성을 확보하기 위해 UI 요소를 통일하는 데 중점을 둡니다. 기존에 사용자 정의 버튼과 로직으로 구현되었던 정렬, 필터, 시간 선택 메뉴를 SwiftUI의 표준 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| Picker(selection: Binding( | ||
| get: { viewModel.state.query.completionFilter }, | ||
| set: { viewModel.send(.setCompletionFilter($0)) } | ||
| )) { | ||
| ForEach([TodoQuery.CompletionFilter.all, .incomplete, .completed], id: \.self) { option in | ||
| Button { | ||
| viewModel.send(.setCompletionFilter(option)) | ||
| } label: { | ||
| selectionLabel( | ||
| title: option.title, | ||
| isSelected: viewModel.state.query.completionFilter == option | ||
| ) | ||
| } | ||
| Text(option.title).tag(option) | ||
| } | ||
| } header: { | ||
| } label: { | ||
| Text("완료 상태") | ||
| } |
There was a problem hiding this comment.
일관성을 위해 sortMenu의 Picker들과 마찬가지로 이 Picker에도 .tint(.blue)를 적용하는 것이 좋겠습니다. 이전 구현에서도 선택된 항목에 파란색 체크마크가 표시되었습니다.
| Picker(selection: Binding( | |
| get: { viewModel.state.query.completionFilter }, | |
| set: { viewModel.send(.setCompletionFilter($0)) } | |
| )) { | |
| ForEach([TodoQuery.CompletionFilter.all, .incomplete, .completed], id: \.self) { option in | |
| Button { | |
| viewModel.send(.setCompletionFilter(option)) | |
| } label: { | |
| selectionLabel( | |
| title: option.title, | |
| isSelected: viewModel.state.query.completionFilter == option | |
| ) | |
| } | |
| Text(option.title).tag(option) | |
| } | |
| } header: { | |
| } label: { | |
| Text("완료 상태") | |
| } | |
| Picker(selection: Binding( | |
| get: { viewModel.state.query.completionFilter }, | |
| set: { viewModel.send(.setCompletionFilter($0)) } | |
| )) { | |
| ForEach([TodoQuery.CompletionFilter.all, .incomplete, .completed], id: \.self) { option in | |
| Text(option.title).tag(option) | |
| } | |
| } label: { | |
| Text("완료 상태") | |
| } | |
| .tint(.blue) |
| Picker(selection: Binding( | ||
| get: { viewModel.state.query.timeFilter }, | ||
| set: { viewModel.send(.setTimeFilter($0)) } | ||
| )) { | ||
| ForEach(PushNotificationQuery.TimeFilter.availableOptions, id: \.self) { option in | ||
| Text(option.title).tag(option) | ||
| } | ||
| } label: { | ||
| Text("기간") | ||
| } |
There was a problem hiding this comment.
일관성을 위해 이 Picker에도 .tint(.blue)를 적용하는 것이 좋겠습니다. 이전 구현에서도 선택된 항목에 파란색 체크마크가 표시되었고, TodoListView의 다른 Picker들에도 적용되어 있습니다.
| Picker(selection: Binding( | |
| get: { viewModel.state.query.timeFilter }, | |
| set: { viewModel.send(.setTimeFilter($0)) } | |
| )) { | |
| ForEach(PushNotificationQuery.TimeFilter.availableOptions, id: \.self) { option in | |
| Text(option.title).tag(option) | |
| } | |
| } label: { | |
| Text("기간") | |
| } | |
| Picker(selection: Binding( | |
| get: { viewModel.state.query.timeFilter }, | |
| set: { viewModel.send(.setTimeFilter($0)) } | |
| )) { | |
| ForEach(PushNotificationQuery.TimeFilter.availableOptions, id: \.self) { option in | |
| Text(option.title).tag(option) | |
| } | |
| } label: { | |
| Text("기간") | |
| } | |
| .tint(.blue) |
1 participant
