Only init conditions for enabled services in InitConditions#1916
Conversation
OpenStackControlPlane CRD Size Report
Threshold reference
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 07s |
Previously, InitConditions() added Unknown conditions for ALL services regardless of whether they were enabled. When the controller short- circuited before reaching a disabled service's reconciler (e.g., during minor update gating), the disabled service's Unknown condition persisted and was mirrored to the Ready condition, producing misleading status like "Octavia not started" even when Octavia was disabled. Only create conditions for services that are actually enabled. Always-on conditions (CAs, Version, Infrastructure, BackupConfig, Client, Ready) remain unconditional. The service reconcilers still handle the enabled-to-disabled transition by removing their conditions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
/retest |
openshift-merge-bot
Bot
merged commit fe7a8d8
into
openstack-k8s-operators:main
2 participants
Previously, InitConditions() added Unknown conditions for ALL services regardless of whether they were enabled. When the controller short- circuited before reaching a disabled service's reconciler (e.g., during minor update gating), the disabled service's Unknown condition persisted and was mirrored to the Ready condition, producing misleading status like "Octavia not started" even when Octavia was disabled.
Only create conditions for services that are actually enabled. Always-on conditions (CAs, Version, Infrastructure, BackupConfig, Client, Ready) remain unconditional. The service reconcilers still handle the enabled-to-disabled transition by removing their conditions.