Add support for configuring environment variables for operators#1718
Add support for configuring environment variables for operators#1718lmiccini wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
lmiccini
force-pushed
the
operator_env_vars
branch
from
787001c to
0515f90
Compare
lmiccini
force-pushed
the
operator_env_vars
branch
from
0515f90 to
478deb4
Compare
|
@lmiccini as a generate feature what you have here is good. and we could add it. I'm not sure about the use case mentioned in the PR for rabbitmq/cluster-operator. If the intent is to allow multiple rabbit operators within a cluster that would be dangerous due to there being only 1 CRD per OCP cluster (the CRDs could be different version, etc). |
|
@lmiccini: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
lmiccini
force-pushed
the
operator_env_vars
branch
from
478deb4 to
929f330
Compare
OpenStackControlPlane CRD Size Report
Threshold reference
|
indeed, removed references to the rabbitmq cluster operator and made this generic. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a7b40406b88d450eb96700b7e4978017 ❌ openstack-k8s-operators-content-provider FAILURE in 3m 56s |
This change allows users to specify custom environment variables for
operator containers through the operatorOverrides field in the OpenStack
CR.
Changes:
- Add Env field to ContainerSpec in the API types
- Implement mergeEnvVars() to merge custom environment variables with defaults
- Update SetOverrides() to apply environment variable overrides
- Enhance operator deployment templates to support both Value and ValueFrom
for environment variables (supporting secrets, configmaps, and field refs)
Usage example:
apiVersion: operator.openstack.org/v1beta1
kind: OpenStack
metadata:
name: openstack
spec:
operatorOverrides:
- name: infra
controllerManager:
env:
- name: SOME_ENV_VAR
value: "some-value"
Co-Authored-By: Claude <noreply@anthropic.com>
lmiccini
force-pushed
the
operator_env_vars
branch
from
929f330 to
a7cbd9b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1b82d221e84546d09d8ac09deeb598fd ❌ openstack-k8s-operators-content-provider FAILURE in 3m 53s |
3 participants
This change allows users to specify custom environment variables for operator containers through the operatorOverrides field in the OpenStack CR.
Changes:
Usage example:
Co-Authored-By: Claude noreply@anthropic.com