Skip to content

[ci-tools]: enable the build_images_if_affected feature#77978

Open
droslean wants to merge 1 commit intoopenshift:mainfrom
droslean:enable-buuu
Open

[ci-tools]: enable the build_images_if_affected feature#77978
droslean wants to merge 1 commit intoopenshift:mainfrom
droslean:enable-buuu

Conversation

@droslean
Copy link
Copy Markdown
Member

@droslean droslean commented Apr 17, 2026

Summary by CodeRabbit

  • Chores
    • Updated build configuration to automatically regenerate images when relevant inputs are affected, improving build consistency.

Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d74deb44-825a-4ac9-b519-22a098edf7bc

📥 Commits

Reviewing files that changed from the base of the PR and between 5463534 and de5cb93.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml

Walkthrough

Added a configuration key build_images_if_affected set to true in the CI operator's main configuration file for the openshift/ci-tools repository. This enables conditional image building based on affected inputs.

Changes

Cohort / File(s) Summary
CI Operator Configuration
ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
Added build_images_if_affected: true configuration key to enable image builds when inputs are affected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: enabling the build_images_if_affected feature in the ci-tools configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This PR modifies only a YAML configuration file, adding a build_images_if_affected field. No Ginkgo test code is present, so the custom check does not apply.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code structure is not applicable; PR only modifies YAML configuration file without test code changes.
Microshift Test Compatibility ✅ Passed The pull request only modifies a CI operator configuration YAML file with no new test code added, making the MicroShift Test Compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request does not introduce any new Ginkgo e2e tests; only a CI operator configuration change is present.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only modifies a CI-operator configuration file to add a build-time feature flag. It does not introduce Kubernetes deployment manifests, operator code, controllers, or any scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this pull request as it only modifies a YAML configuration file without any executable code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI/CD configuration file, no new Ginkgo e2e tests added; check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 17, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@droslean: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from deepsm007 and psalajova April 17, 2026 14:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@droslean
Copy link
Copy Markdown
Member Author

/hold

@droslean
Copy link
Copy Markdown
Member Author

openshift/ci-tools#5105

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

@droslean: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config-metadata de5cb93 link true /test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants