prowgen: migrate rehearsal configs to ci-operator config#77841
Open
Prucek wants to merge 1 commit intoopenshift:mainfrom
Open
prowgen: migrate rehearsal configs to ci-operator config#77841Prucek wants to merge 1 commit intoopenshift:mainfrom
Prucek wants to merge 1 commit intoopenshift:mainfrom
Conversation
…r config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
WalkthroughThis pull request migrates rehearsal-disable configurations from centralized Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
added
the
rehearsals-ack
Contributor
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.6.yaml`:
- Line 157: The change adds the config field "disable_rehearsal" which depends
on openshift/ci-tools#5106; do not merge this commit as-is—either remove the
"disable_rehearsal: true" line from the CI config or hold this PR until
openshift/ci-tools#5106 is merged, so the prowgen support exists before adding
the "disable_rehearsal" field.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b0b3bbe-2393-4d2c-8d1b-78a8e47cb87f
📒 Files selected for processing (32)
ci-operator/config/openshift-psap/forge/.config.prowgenci-operator/config/openshift-psap/forge/openshift-psap-forge-main.yamlci-operator/config/openshift-psap/forge/openshift-psap-forge-main__jump.yamlci-operator/config/openshift-psap/fournos/.config.prowgenci-operator/config/openshift-psap/fournos/openshift-psap-fournos-main.yamlci-operator/config/openshift-psap/topsail/.config.prowgenci-operator/config/openshift-psap/topsail/openshift-psap-topsail-main__cont_bench.yamlci-operator/config/openshift-psap/topsail/openshift-psap-topsail-main__jump.yamlci-operator/config/openshift-psap/topsail/openshift-psap-topsail-main__mac_ai.yamlci-operator/config/openshift/backplane-cli/.config.prowgenci-operator/config/openshift/osde2e/.config.prowgenci-operator/config/openshift/osde2e/openshift-osde2e-main.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/.config.prowgenci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-main.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-1.0.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-1.1.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.0.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.1.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.2.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.3.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.4.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.5.yamlci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.6.yamlci-operator/config/stolostron/submariner-addon/.config.prowgenci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-main.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.11.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.12.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.13.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.14.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.15.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.16.yamlci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.17.yaml
💤 Files with no reviewable changes (7)
- ci-operator/config/openshift-psap/forge/.config.prowgen
- ci-operator/config/stolostron/submariner-addon/.config.prowgen
- ci-operator/config/openshift-psap/topsail/.config.prowgen
- ci-operator/config/openshift-psap/fournos/.config.prowgen
- ci-operator/config/rh-ecosystem-edge/kernel-module-management/.config.prowgen
- ci-operator/config/openshift/backplane-cli/.config.prowgen
- ci-operator/config/openshift/osde2e/.config.prowgen
| clone: true | ||
| from: go-builder | ||
| - as: check-commits-count | ||
| disable_rehearsal: true |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
gh pr view 5106 --repo openshift/ci-tools --json state,mergedAt,title,urlRepository: openshift/release
Length of output: 212
Do not merge until openshift/ci-tools#5106 is merged.
The disable_rehearsal field depends on the pending PR openshift/ci-tools#5106 ("prowgen: add rehearsal control to ci-operator config"). Merging this change before that PR is merged will cause config processing to fail.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/config/rh-ecosystem-edge/kernel-module-management/rh-ecosystem-edge-kernel-module-management-release-2.6.yaml`
at line 157, The change adds the config field "disable_rehearsal" which depends
on openshift/ci-tools#5106; do not merge this commit as-is—either remove the
"disable_rehearsal: true" line from the CI config or hold this PR until
openshift/ci-tools#5106 is merged, so the prowgen support exists before adding
the "disable_rehearsal" field.
Contributor
|
@Prucek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.config.prowgento ci-operator config fields (prowgen.disable_rehearsalsand per-testdisable_rehearsal).config.prowgenfiles that only contained rehearsal config🤖 Generated with Claude Code
Summary by CodeRabbit