[Release-4.16] OCPBUGS-83777: Fix CVE-2026-29063 in immutable#392
[Release-4.16] OCPBUGS-83777: Fix CVE-2026-29063 in immutable#392MrSanketkumar wants to merge 1 commit intoopenshift:release-4.16from
Conversation
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-83777, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds Yarn Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrSanketkumar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-83777, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
102-102: Pinwebpackresolution to exact version for deterministic installs.Line 102 uses a range (
^5.68.0) inresolutions, whiledevDependencies.webpackis pinned to5.91.0(line 96). Though yarn.lock currently resolves to 5.91.0, the range allows potential drift on lockfile refresh. For reproducibility and security stability, pin the resolution exactly:Proposed change
- "webpack": "^5.68.0", + "webpack": "5.91.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 102, The "resolutions" entry currently pins "webpack" to a range ("^5.68.0") which can drift; update the resolutions key to use the exact version that matches devDependencies.webpack (change the "webpack" resolution from "^5.68.0" to "5.91.0") so installs are deterministic and consistent with devDependencies.webpack.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@package.json`:
- Line 102: The "resolutions" entry currently pins "webpack" to a range
("^5.68.0") which can drift; update the resolutions key to use the exact version
that matches devDependencies.webpack (change the "webpack" resolution from
"^5.68.0" to "5.91.0") so installs are deterministic and consistent with
devDependencies.webpack.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: df733c3c-f990-408a-9885-261ef464fae8
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json
|
/jira refresh |
|
@MrSanketkumar: This pull request references Jira Issue OCPBUGS-83777, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@MrSanketkumar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://www.cve.org/CVERecord?id=CVE-2026-29063
Summary by CodeRabbit