Skip to content

[Release-4.16] OCPBUGS-83777: Fix CVE-2026-29063 in immutable#392

Open
MrSanketkumar wants to merge 1 commit intoopenshift:release-4.16from
MrSanketkumar:CVE-2026-29063-4.16-immutable
Open

[Release-4.16] OCPBUGS-83777: Fix CVE-2026-29063 in immutable#392
MrSanketkumar wants to merge 1 commit intoopenshift:release-4.16from
MrSanketkumar:CVE-2026-29063-4.16-immutable

Conversation

@MrSanketkumar
Copy link
Copy Markdown

@MrSanketkumar MrSanketkumar commented Apr 24, 2026

https://www.cve.org/CVERecord?id=CVE-2026-29063

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to ensure compatibility and stability.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-83777, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-83777 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://www.cve.org/CVERecord?id=CVE-2026-29063

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Walkthrough

Adds Yarn resolutions field to package.json pinning versions of three packages: @openshift-console/dynamic-plugin-sdk/immutable to 3.8.3, @openshift-console/dynamic-plugin-sdk-internal/immutable to 3.8.3, and sass/immutable to 4.3.8. Adjusts webpack resolution formatting to accommodate additional entries.

Changes

Cohort / File(s) Summary
Dependency Version Pinning
package.json
Added Yarn resolutions overrides for three packages to enforce specific versions. Modified existing webpack resolution entry formatting with trailing comma.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references the CVE-2026-29063 security fix and mentions immutable dependencies, which aligns with the core change of pinning immutable package versions to address the vulnerability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This custom check validates Ginkgo test name stability, but the repository is a JavaScript/TypeScript Node.js plugin with no Go code or Ginkgo tests.
Test Structure And Quality ✅ Passed This pull request modifies only package.json with version constraints and contains no Ginkgo test code changes.
Microshift Test Compatibility ✅ Passed PR is a TypeScript/JavaScript console plugin with no Go test additions; Ginkgo test patterns not found in diff.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies package.json for dependency versions; no Ginkgo e2e tests or test files added.
Topology-Aware Scheduling Compatibility ✅ Passed This pull request modifies only package.json to pin dependency versions for a security fix (CVE-2026-29063). It does not add or modify any deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check is not applicable to this PR as it only modifies package.json dependency versions in a Node.js/TypeScript project with no executable code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request contains only a package.json dependency version update to address CVE-2026-29063 and does not add any new Ginkgo e2e tests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from metalice and vojtechszocs April 24, 2026 14:36
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrSanketkumar
Once this PR has been reviewed and has the lgtm label, please assign pcbailey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrSanketkumar
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@openshift-ci-robot
Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-83777, which is invalid:

  • expected Jira Issue OCPBUGS-83777 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

https://www.cve.org/CVERecord?id=CVE-2026-29063

Summary by CodeRabbit

  • Chores
  • Updated internal dependencies to ensure compatibility and stability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

102-102: Pin webpack resolution to exact version for deterministic installs.

Line 102 uses a range (^5.68.0) in resolutions, while devDependencies.webpack is pinned to 5.91.0 (line 96). Though yarn.lock currently resolves to 5.91.0, the range allows potential drift on lockfile refresh. For reproducibility and security stability, pin the resolution exactly:

Proposed change
-    "webpack": "^5.68.0",
+    "webpack": "5.91.0",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 102, The "resolutions" entry currently pins "webpack"
to a range ("^5.68.0") which can drift; update the resolutions key to use the
exact version that matches devDependencies.webpack (change the "webpack"
resolution from "^5.68.0" to "5.91.0") so installs are deterministic and
consistent with devDependencies.webpack.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@package.json`:
- Line 102: The "resolutions" entry currently pins "webpack" to a range
("^5.68.0") which can drift; update the resolutions key to use the exact version
that matches devDependencies.webpack (change the "webpack" resolution from
"^5.68.0" to "5.91.0") so installs are deterministic and consistent with
devDependencies.webpack.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: df733c3c-f990-408a-9885-261ef464fae8

📥 Commits

Reviewing files that changed from the base of the PR and between af82cce and 510d738.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

@MrSanketkumar
Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-83777, which is invalid:

  • expected dependent Jira Issue OCPBUGS-79445 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

@MrSanketkumar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants